I think this is prone to error since it requires someone to take reviewer 
status from someone else, or assume responsibility for a file that doesn't have 
a reviewer yet. Generally, I just use |hg blame| and |hg blame -u| to see who 
has been working on the file and how recently. If I ask the wrong person to 
review, they can just punt it to the right person without any real harm.

Doug

----- Original Message -----
From: "Honza Bambas" <hbam...@mozilla.com>
To: dev-platform@lists.mozilla.org
Sent: Thursday, February 13, 2014 4:23:07 PM
Subject: Individual files should have a reviewer reference

An optional /* @reviewer: m...@foo.com */ comment under the license would 
do.  If not present, find reviewer the usual way (not always hitting the 
right person).

Reason is that despite we have peer lists, sometimes files are 
written/maintained by non-peers of the module a file is in or should be 
reviewed only by a specific peer of the module that authored or 
currently maintains the file.

Opinions?
-hb-
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to