On Mon, Feb 10, 2014 at 1:45 PM, Gavin Sharp <ga...@gavinsharp.com> wrote:
> > Another issue, are you planning to upstream your work to Mozilla in the > > near future? > > Regardless of intent, I don't think any OS/2 support patches should be > accepted in mozilla-central. A platform port like that is too "high > touch" and low-value to be worth the maintenance burden in > mozilla-central, unfortunately. > > We should fix bug 969757 and accept that any OS/2 support efforts > going forward need to be maintained outside of mozilla-central. > OK, that works for me. FWIW any time that you guys decide to revive this code in your own private branch, you can simply revert the patch to bug 969757 and merge it against the trunk, and start working on the port with that baseline. Cheers, -- Ehsan <http://ehsanakhgari.org/> > On Mon, Feb 10, 2014 at 8:19 AM, Ehsan Akhgari <ehsan.akhg...@gmail.com> > wrote: > > Hi Dmitriy, > > > > > > On Mon, Feb 10, 2014 at 4:46 AM, Dmitriy Kuminov <d...@dmik.org> wrote: > > > >> Gregory, > >> > >> 08 февр. 2014 г., в 10:57, Gregory Szorc <g...@mozilla.com> написал(а): > >> > >> > On 8/7/13, 1:00 PM, d...@dmik.org wrote: > >> >> Regarding the main subject. There are many OS/2 parts that are still > >> valid (e.g. the NSPR code) so if you will drop them we will have to > reapply > >> them back in our repo. And if we push it back later you will have to > >> reapply them again. This doesn't make sense to me — if you are going to > >> accept our patches at some later stage. If you are certainly not, then > you > >> may go on with that. > >> >> > >> >> I'm also ready to listen to any other ideas on how we can collaborate > >> in this case. > >> > > >> > I just realized I never replied to this thread! > >> > >> I’m glad that someone reacted, finally :) > >> > >> > Given: > >> > > >> > a) the in-tree OS/2 port hasn't worked in over 2 years > >> > b) the OS/2 port is using a "shadow" build system, independent of the > >> official one > >> > c) there appears to be little desire to use the official build system > >> for an OS/2 port at this time > >> > > >> > It's my determination that OS/2 has little use in the Firefox *build > >> system*. (The OS/2 port may wish for some references to remain in C++.) > >> > > >> > Bug 969757 currently has a patch to remove most remnants of OS/2 from > >> the *entire* tree. If you have any interest in preserving references to > >> OS/2 in the tree, now would be the time to speak up. > >> > >> The current situation is little bit different from what it was in my > last > >> answer. We had to switch back to the original build system for the time > >> being. There turned out to be soooooo many things to do (Mozilla is a > giant > >> monster source wise) that we postponed the task of porting the build > system > >> to kBuild and directed our (limited) resources to porting Mozilla itself > >> (and went pretty far on that way — FF17 now runs on OS/2 and even > >> out-of-process Flash works). > >> > >> So I would like to ask you to preserve OS/2 in configure and makefiles > for > >> now. > >> > > > > Can you please point us to where this work is happening? I'm only aware > of > > this repository: <https://github.com/bitwiseworks/mozilla-os2> > > > > Do you plan to move your development to trunk in the near future? The > > Firefox 17 ESR code base that the mozilla-os2 repository is based on is > > *ancient* and there will be a lot of changes when you try to merge with > the > > current trunk, which means that a lot of the fixes you're working on will > > be obsolete by the time you do the merge, and you may need to repeat a > lot > > of work on top of the new trunk. > > > > Another issue, are you planning to upstream your work to Mozilla in the > > near future? The current state of the OS2 port on trunk is unclear. We > > know that it has probably been broken for at least the last 2 years due > to > > a missing TimeStamp implementation for OS2 and we have been carrying > around > > this broken code for a long time. As Gregory mentioned, I have a patch > in > > bug 969757 to remove this code completely, but obviously taking that > patch > > doesn't make any sense if you're going to move to trunk at some point in > > the near future. (Note that I think some of the recent build system > > changes have started to remove some OS2 bits from the new moz.build based > > build system, so porting your work to trunk will probably require finding > > and fixing those cases as well.) > > > > Thanks! > > -- > > Ehsan > > <http://ehsanakhgari.org/> > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
