On Sun, Feb 2, 2014 at 5:01 PM, Anthony Jones <ajo...@mozilla.com> wrote:
> On 31/01/14 13:25, Nicholas Nethercote wrote: > > I think what Bobby is saying is that a tool which restyles only lines > > that have only been modified isn't much use. For example, much of > > XPConnect uses 4-space indents, when it should use 2-space indents, > > and fixing that cannot be sensibly done in any way other than an > > entire file (or files) at a time. (And if we're going to fix > > indentation, obviously we should fix any other style problems at the > > same time.) > > In order to make this happen I've run clang-format on XPConnect and > uploaded it to bug 966840. > XPConnect currently follows JS-style, which is the most divergent style in the tree (in particular, 4-space indents mean that a restyle is going to rewrite every line). As such, I don't think it's a great place to prototype clang-format restyles. At minimum, we should do dom/ and content/ first. bholley _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
