Anthony Jones writes:

> There is also some vagueness and inconsistency around:
>
> bool
> MyClass::MyFunction()
>
> vs
>
> bool MyClass::MyFunction()
>
> Most of the code seems to do this only for top-level functions i.e. when
> not already indented. I'd like some clarification on the rule here. It
> seems to be applied differently in different parts of the code.

Neil <n...@parkwaycc.co.uk> writes:

> Bobby Holley wrote:
>
>>I'm pretty sure the former is correct per Gecko style. Benjamin can confirm.
>>  
>>
> My understanding is that it helps when you diff -p (which is one
> of our preferred diff flags) as you get as much of the function
> name as possible in the diff.

It helps diff -p when the function is not indented.

When the function is indented, such as inline functions in a class
declaration, diff -p doesn't know where the function starts, so it
tells you whether the block is public, private, etc.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to