On 2014-01-07, at 17:49, Joshua Cranmer <pidgeo...@gmail.com> wrote:
> Since I'm seeing a lot of people advocating that the wrap margin should be
> 100,
> let me reiterate
> David Baron's comment that the wrap margin must either be 80 or infinite […]
I have always preferred no wrapping, with the line length limit being a
guideline that encourages use of splitting in the following form:
- pc._localIdp.appendIdentityToSDP(sdp, pc._impl.fingerprint, function(sdp,
assertion) {
+ let fp = pc._impl.fingerprint;
+ pc._localIdp.appendIdentityToSDP(sdp, fp, function(sdp, assertion) {
Rather than forced wrapping:
- pc._localIdp.appendIdentityToSDP(sdp, pc._impl.fingerprint, function(sdp,
assertion) {
+ pc._localIdp.appendIdentityToSDP(sdp,
+ pc._impl.fingerprint,
+ function(sdp, assertion) {
The problem there being that the only realistic option for handling this is
checking.
So maybe this can bifurcate the bike shedding discussion further: do you want
to have a tool wrap to X, or do you want a tool to block patches that exceed X?
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
