On Tue, Dec 03, 2013 at 12:18:46AM -0500, Boris Zbarsky wrote: > On 12/2/13 11:39 PM, Mike Hommey wrote: > >1. By the way, those type of bugs that show up at different number of > >unified sources are existing type of problems waiting to arise when we > >add source files, and running non-unified builds doesn't catch them. > > A number of the ones I saw you file seemed to do with #defines in > .cpp files that then affect other .cpp files. > > I would argue that any .cpp file that #defines something and doesn't > #undef it shouldn't be unified... Is there any way we can enforce > that at compile-time?
Those bugs you're talking about are really about a macro having the same name as something else in the tree. We just happen to be lucky that those instances of macros are in .cpp files, but they could very well have been in headers, and we might have such problems in hiding already. So if we go after something at the static analysis level, that should be that as well, not only that #defines are #undefed. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
