On 9/18/13 4:20 PM, smaug wrote:
I don't care too much whether we use Handle/Rooted<Foo> or typedefs but consistency is always good.
In that case, we might as well switch to typedefs. JS engine hackers are landing them in non-JS code anyway, because they're so used to it in their own code (c.f. bug 884410 and bug 930782 at the very least, making changes to DOM code to add typedef uses with no review from DOM peers).
So at this point we have a bunch of code that's wonderfully inconsistent, and trying to remove the typedefs from it will just lead to more sneak landings like the above.
What we need now is someone to own the change in non-js-engine code. -Boris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform