Some of us over in #mobile brainstormed a list of things that reviewers
(and patch-writers) should check for in patches. The idea is to have a
handy list of these things that often get forgotten, overlooked, or
otherwise slip through. I have put up our list on the MDN wiki at [1] -
please feel free to add/update (and most importantly, use!) the page.
Some of the items are specific to working on Fennec, so I tried to make
that clear by annotating those items. Also note that the list is
specifically *not* intended for new contributors at Mozilla, because I
expect it to evolve to contain arcane gotchas and stuff (if it hasn't
already) that would generally be overwhelming for new contributors. For
new contributor patches, I expect that the reviewer/mentor would use the
checklist to identify specific problems.
[1]
https://developer.mozilla.org/en-US/docs/Developer_Guide/Reviewer_Checklist
Cheers,
kats
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
