You can ignore unnecessary roots. They don't hurt us right now and we can fix them after everything else is done.
On Sat, May 4, 2013 at 9:43 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote: > There are a ton of messages in that list of the following form: > > Function 'foo' has unnecessary root 'bar' in 'baz.cpp:123' > > As far as I can tell they seem to map to mozilla::ErrorResult values being > used in some contexts. Should we just ignore them? > > Ehsan > > > On 2013-05-04 12:56 PM, Boris Zbarsky wrote: >> >> On 4/23/13 11:18 AM, Ehsan Akhgari wrote: >>> >>> Can the stuff in objdir/dom/bindings be fixed whole-sale by changing the >>> WebIDL codegen? >> >> >> This is nearly done: we're down to the issues in bug 868715, which >> largely affect the js-implemented codegen at the moment, and the problem >> of what to do with TypedArray structs. Sadly, this last doesn't fall >> into the "easy and tedious" bucket. :( >> >> David Zbarsky has also fixed all the hazards in classinfo and a bunch >> more in various other files under dom/, so we're down to about 350 >> rooting hazards in the browser, from about 2500 a week or so ago. >> >> If people want to help out, I'm including the full list of browser >> hazards at the end of this mail. Please comment in bug 867844 if you >> plan to fix the content/ hazards and please comment in bug 868312 if you >> plan to fix things in dom/, and in other cases file bugs blocking >> 831379, just so we can avoid duplicating work. >> >> -Boris >> >> P.S. Full hazard list can be found at >> http://people.mozilla.org/~sfink/analysis/browser/rootingHazards.txt and >> the list of relevant files as of this morning is: >> >> 1 hazards in js/src/jsapi-tests/testXDR.cpp >> 1 hazards in js/xpconnect/src/XPCConvert.cpp >> 1 hazards in dom/ipc/StructuredCloneUtils.cpp >> 1 hazards in js/src/ion/AsmJS.cpp >> 1 hazards in dist/include/mozilla/dom/CallbackFunction.h >> 1 hazards in js/xpconnect/src/XPCVariant.cpp >> 1 hazards in content/media/webaudio/AudioBuffer.cpp >> 1 hazards in dom/workers/Exceptions.cpp >> 1 hazards in js/src/ctypes/typedefs.h >> 1 hazards in dom/workers/ChromeWorkerScope.cpp >> 1 hazards in js/src/ion/Lowering.cpp >> 1 hazards in clude/molude/mozilla/dom/TypedArray.h >> 1 hazards in content/xul/document/src/XULDocument.cpp >> 1 hazards in js/src/ctypes/CTypes.cpp >> 1 hazards in js/src/vm/ParallelDo.cpp >> 1 hazards in content/base/src/EventSource.cpp >> 1 hazards in content/base/src/nsNodeUtils.cpp >> 1 hazards in js/xpconnect/src/XPCJSRuntime.cpp >> 1 hazards in toolkit/xre/nsEmbedFunctions.cpp >> 1 hazards in dist/include/mozilla/dom/BindingUtils.h >> 1 hazards in dom/indexedDB/IDBRequest.cpp >> 1 hazards in dom/indexedDB/IDBDatabase.cpp >> 1 hazards in clude/jslude/js/Vector.h >> 1 hazards in content/events/src/nsEventListenerManager.cpp >> 1 hazards in content/base/src/nsContentUtils.cpp >> 1 hazards in content/html/content/src/UndoManager.cpp >> 1 hazards in content/xbl/src/nsXBLSerialize.cpp >> 1 hazards in content/html/content/src/HTMLMediaElement.cpp >> 1 hazards in dom/workers/ImageData.cpp >> 1 hazards in dom/camera/CameraControlImpl.cpp >> 1 hazards in content/xslt/src/xslt/txMozillaXSLTProcessor.cpp >> 1 hazards in js/jsd/jsd_obj.cpp >> 1 hazards in content/events/src/nsEventListenerService.cpp >> 1 hazards in security/manager/ssl/src/nsCrypto.cpp >> 1 hazards in content/html/content/src/nsGenericHTMLElement.cpp >> 1 hazards in tools/profiler/TableTicker.cpp >> 1 hazards in js/xpconnect/src/nsDOMQS.h >> 1 hazards in content/xul/document/src/nsXULPrototypeDocument.cpp >> 1 hazards in js/xpconnect/src/XPCQuickStubs.cpp >> 1 hazards in content/xbl/src/nsXBLBinding.cpp >> 1 hazards in widget/xpwidgets/GfxInfoBase.cpp >> 1 hazards in js/xpconnect/src/XPCQuickStubs.h >> 1 hazards in content/xbl/src/nsXBLDocumentInfo.cpp >> 1 hazards in toolkit/components/telemetry/Telemetry.cpp >> 1 hazards in dom/camera/DOMCameraControl.cpp >> 1 hazards in content/base/src/nsInProcessTabChildGlobal.h >> 1 hazards in dom/mobilemessage/src/ipc/SmsIPCService.cpp >> 1 hazards in js//inclst/include/mozilla/dom/workers/bindings/EventTarget.h >> 1 hazards in dom/indexedDB/IndexedDatabaseManager.cpp >> 1 hazards in dist/include/mozilla/dom/EventListenerBinding.h >> 1 hazards in content/base/src/nsContentList.cpp >> 1 hazards in content/canvas/src/CanvasUtils.h >> 1 hazards in storage/src/mozStorageAsyncStatementParams.cpp >> 1 hazards in js/src/vm/Shape.cpp >> 1 hazards in tools/profiler/ProfileEntry.cpp >> 1 hazards in content/base/src/nsDOMBlobBuilder.cpp >> 1 hazards in dom/mobilemessage/src/SmsManager.cpp >> 1 hazards in clude/molude/mozilla/jsipc/ContextWrapperChild.h >> 1 hazards in dom/file/ArchiveRequest.cpp >> 1 hazards in content/html/document/src/nsHTMLDocument.cpp >> 1 hazards in content/base/src/nsDocument.h >> 1 hazards in js/src/ion/IonCaches.cpp >> 1 hazards in content/xul/content/src/nsXULElement.cpp >> 1 hazards in js/src/vm/Debugger.cpp >> 1 hazards in dom/base/DOMRequest.cpp >> 2 hazards in dom/network/src/TCPSocketChild.cpp >> 2 hazards in dom/system/OSFileConstants.cpp >> 2 hazards in content/xul/document/src/nsXULPrototypeCache.cpp >> 2 hazards in content/base/src/nsXMLHttpRequest.cpp >> 2 hazards in dom/devicestorage/nsDeviceStorage.cpp >> 2 hazards in storage/src/mozStorageStatementParams.cpp >> 2 hazards in content/base/src/WebSocket.cpp >> 2 hazards in storage/src/mozStorageStatementRow.cpp >> 2 hazards in js/jsd/jsd_stak.cpp >> 2 hazards in content/xul/templates/src/nsXULTemplateBuilder.cpp >> 2 hazards in js/src/jswrapper.cpp >> 3 hazards in tools/profiler/JSObjectBuilder.cpp >> 3 hazards in dom/workers/EventTarget.cpp >> 3 hazards in js/xpconnect/src/XPCWrappedNative.cpp >> 3 hazards in dist/include/nsTArrayHelpers.h >> 3 hazards in content/base/src/nsINode.cpp >> 3 hazards in storage/src/mozStorageAsyncStatementJSHelper.cpp >> 3 hazards in dom/workers/File.cpp >> 3 hazards in dom/network/src/TCPSocketParent.cpp >> 3 hazards in js/ipc/ObjectWrapperParent.cpp >> 3 hazards in dom/indexedDB/IDBFactory.cpp >> 3 hazards in dom/base/nsGlobalWindow.cpp >> 4 hazards in storage/test/test_StatementCache.cpp >> 4 hazards in content/base/src/nsDOMDataChannel.cpp >> 4 hazards in dom/workers/XMLHttpRequest.cpp >> 4 hazards in dom/indexedDB/IDBObjectStore.cpp >> 4 hazards in content/canvas/.st/inclst/include/mozilla/dom/TypedArray.h >> 4 hazards in dom/workers/Worker.cpp >> 4 hazards in startupcache/test/TestStartupCache.cpp >> 4 hazards in dom/base/nsDOMClassInfo.cpp >> 4 hazards in js/jsd/jsd_scpt.cpp >> 5 hazards in dom/plugins/base/nsJSNPRuntime.cpp >> 5 hazards in dom/mobilemessage/src/MobileMessageManager.cpp >> 5 hazards in storage/src/mozStorageStatementJSHelper.cpp >> 5 hazards in dom/workers/WorkerPrivate.cpp >> 6 hazards in content/base/src/nsObjectLoadingContent.cpp >> 6 hazards in content/canvas/src/CanvasRenderingContext2D.cpp >> 7 hazards in content/base/src/nsFrameMessageManager.cpp >> 7 hazards in caps/src/nsScriptSecurityManager.cpp >> 8 hazards in dom/workers/Location.cpp >> 8 hazards in dom/workers/EventListenerManager.cpp >> 9 hazards in dom/workers/Events.cpp >> 9 hazards in dom/base/nsJSEnvironment.cpp >> 11 hazards in dom/camera/DOMCameraCapabilities.cpp >> 12 hazards in dom/bindings/TestJSImplGenBinding.cpp >> 12 hazards in js/jsd/jsd_xpc.cpp >> 13 hazards in dom/mobilemessage/src/MmsMessage.cpp >> 14 hazards in js/ipc/ObjectWrapperChild.cpp >> 14 hazards in dom/bindings/TestJSImplInheritanceGenBinding.cpp >> 16 hazards in dom/workers/WorkerScope.cpp >> 23 hazards in js/jsd/jsd_val.cpp >> _______________________________________________ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
