On Sunday 2012-10-07 13:38 -0700, Daniel Holbert wrote: > To fix the warning and actually get inlining behavior, I think we need > to do either of the following: > (a) include "inline" alongside NS_ALWAYS_INLINE in each usage > (b) or, change the definition of NS_ALWAYS_INLINE to include "inline"
I think (b) is better than (a) because it means less work in the future if there's, say, a compiler that requires the "inline" and the __attribute__((...)) to be in a particular order (or, worse, one compiler that requires one order and another compiler that requires the opposite). -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla http://www.mozilla.org/ 𝄂 _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
