http://mxr.mozilla.org/mozilla-central/ident?i=PRUptrdiff
In NSPR, this is defiend as "typedef unsigned long PRUptrdiff;".
ptrdiff_t is C99 standard and allows negative, but uintptr_t is unsigned.
On 2012/08/24 10:44, Bas Schouten wrote:
Is ptrdiff_t not portable? As far as I know it's part of the standard.
----- Original Message -----
From: "Makoto Kato" <m_k...@ga2.so-net.ne.jp>
To: dev-platform@lists.mozilla.org
Sent: Friday, August 24, 2012 1:30:39 AM
Subject: Re: Gecko switched to use standard integer types
How about PRUptrdiff? Most cases can changes to uintptr_t.
On 2012/08/23 1:35, Ehsan Akhgari wrote:
I just landed the patches in bug 579517 which switch all of the code in
mozilla-central and comm-central [1] to use the standard integer types
as opposed to NSPR integer types. Here's what this means to you:
* If you're a developer, this will most likely bitrot your patches. You
can use this script [2] in order to unbitrot your patches if you use
mercurial queues. Also, please get into the habit of using stdint types
(such as int16_t and uint32_t) as opposed to NSPR numeric types (such as
PRInt16 and PRUint32).
* If you maintain a branch which merges against mozilla-central, you
probably want to merge mozilla-central into it as soon as possible.
There will probably be merge conflicts. The easiest way to resolve them
is to take your branch's version in the conflicts and then run the
script that I used for the conversion again so that you make sure you're
not adding more NSPR numeric type usages in your branch.
* If you want to back out a patch which landed before this, there's
probably a bunch of manual conflict resolution that you need to do.
* If you talk to new Mozilla contributors regularly, you probably won't
need to explain to them what these NSPR types are any more. :-)
* If you're not in any of the above categories, this work will probably
not affect you.
Cheers,
Ehsan
[1] (except for NSPR and NSS)
[2] https://bugzilla.mozilla.org/attachment.cgi?id=650572
[3] https://bugzilla.mozilla.org/attachment.cgi?id=653946
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
