Hi Ashwin,

> On Jul 6, 2017, at 03:24, Ashwin Kumar <[email protected]> wrote:
> 
> Looks like adding maxBitrate to the encoding params helped. Now I see that FF 
> is transmitting all three streams.
> 
> But like Lorenzo, I also have the same question - "what's the syntax for 
> maxBitrate? is it in bps? Asking as the 40000 in the example seems quite low. 
> “

As I replied to Lorenzo before already: the reason the number is so low is that 
we are running all of our automated tests on super low resolutions to save 
resources.

Best
  Nils


> 
> On Thursday, July 6, 2017 at 1:13:34 PM UTC+5:30, Lorenzo Miniero wrote:
>> Il giorno giovedì 6 luglio 2017 01:13:01 UTC+2, Nils Ohlmeier ha scritto:
>>>> On Jul 5, 2017, at 05:28, [email protected] wrote:
>>>> 
>>>> We are testing FF/Simulcast with our SFU, expecting FF to send RTP of all 
>>>> three streams as advertised in SDP.
>>>> 
>>>> simulcast  parameters
>>>> {
>>>>                       encodings: [{
>>>>                           rid: "720",
>>>>                       }, {
>>>>                           rid: "360",
>>>>                           scaleResolutionDownBy: 2,
>>>>                       }, {
>>>>                           rid: "180",
>>>>                           scaleResolutionDownBy: 4,
>>>>                       }, ]
>>>> };
>>> 
>>> Not sure if it makes a difference, but have you tried to add the maxBitrate 
>>> parameter to the encodings?
>>> Like here: 
>>> http://searchfox.org/mozilla-central/source/dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html#62
>>>  
>>> <http://searchfox.org/mozilla-central/source/dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html#62>
>>>  
>>> <http://searchfox.org/mozilla-central/source/dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html#62
>>>  
>>> <http://searchfox.org/mozilla-central/source/dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html#62>>
>>> 
>> 
>> 
>> Hi Nils,
>> 
>> as a side note, what's the syntax for maxBitrate? is it in bps? Asking as 
>> the 40000 in the example seems quite low.
>> 
>> Thanks,
>> Lorenzo
>> 
>> 
>>>> 
>>>> Offer:
>>>> 
>>>> a=simulcast: send rid=720;360;180
>>>> a=extmap:3/sendonly urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id
>>>> a=rid:720 send
>>>> a=rid:360 send
>>>> a=rid:180 send
>>>> 
>>>> Answer:
>>>> 
>>>> a=simulcast: recv rid=720;360;180
>>>> a=extmap:3/recvonly urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id
>>>> a=rid:720 recv
>>>> a=rid:360 recv
>>>> a=rid:180 recv
>>>> 
>>>> But when we check the outgoing rtp packet header extension, we can see 
>>>> that it is sending packets for resolution 180p (because the extension is 
>>>> corresponding to rid 180)
>>>> 
>>>> As per the simulcast, we expect it to send all three streams(720, 360 & 
>>>> 180). Any idea  what are we doing wrong here?
>>> 
>>> Have you looked at all RTP packets?
>>> I’m asking because I noticed that in Firefox 56 we only include the RID in 
>>> the very first packet for each frame. So you need to carefully search for 
>>> the beginning of the next frame to find the 2nd and 3rd RID.
>>> 
>>> Best regards
>>>  Nils Ohlmeier
> 
> _______________________________________________
> dev-media mailing list
> [email protected] <mailto:[email protected]>
> https://lists.mozilla.org/listinfo/dev-media 
> <https://lists.mozilla.org/listinfo/dev-media>

Attachment: signature.asc
Description: Message signed with OpenPGP

_______________________________________________
dev-media mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-media

Reply via email to