On Mon, May 23, 2016 at 3:31 PM, Alexis Mousset < [email protected]> wrote:
> I have run the ncf tests against this build, and found no regression > related to iterations. However, some tests are broken because strings > containing unexpandable variables are skipped. Is it a intended change of > behavior in 3.10? > *Empty* slists are completely skipped, there is no iteration with $(varname) as the string. Unexpanded string variables are not skipped though. IMHO it would make sense to skip all promises that contain unexpanded strings, I would really like to see that change happening. But I held back because I'm not sure, how would you distinguish a string containing the dollar-parenthesis characters on purpose? > > I did a quick comparison with 3.9b1 and found a speedup around 7% with > this build, but the tests do not use a lot of nested iterations. > Great! Speedup for the common case should increase even more once I remove all the debug hooks I've spread in the codebase and get a release build out. Thanks for testing! Dimitris -- You received this message because you are subscribed to the Google Groups "dev-cfengine" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/dev-cfengine/CALSpUb2KWfQF7wK%2B-qbwY66Gr6bHbiy6Ycb1vTHWrnF_aQR%2Bfg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
