>From what you've said, I think the next step will be submitting a patch -- https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html#to-submit-a-patch
Your strategy for choosing a reviewer is not a bad one. Choosing a reviewer can be difficult! If that person is not the correct person, they will probably know who to re-assign the review to. Dustin On Fri, Jan 17, 2020 at 2:35 PM <sanchit.arora.2...@gmail.com> wrote: > I finally managed to figure out my first bug on Firefox but need little > bit help to confirm that I successfully submitted patch or not. > > So I tried to follow instructions given here: > https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html > > The steps I followed: > 1. Changed my local codebase > 2. Commit the patch using "Bug <bug number> - <Description>. r=<reviewer> > > Now I have 2 questions: > > 1. Have I successfully submitted the patch or there is something more to > do? I only followed the steps under "To write a patch" heading so what > exactly is the difference between writing a patch and submitting it? > > 2. I wrote the reviewer name as the one who last reviewed a bug on that > file and not as the mentor or reporter of that bug. So what I did is > correct or I should put the name of the mentor as reviewer? > > Thanks in advance for taking out some time to help me :) > _______________________________________________ > dev-builds mailing list > dev-builds@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-builds >
_______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
