On Fri, Feb 1, 2019 at 4:39 PM Mike Hommey <[email protected]> wrote:
> Considering modules can execute code when they are being imported (and
> some do), reordering should be done with extra care.
>
Yes, we'll need to be careful. Though I'd make the argument that if a
module depends on import order to function correctly, that's something
we should fix anyway :).
Relatedly, how is the following handled?
>
> ```
> import sys
> sys.path.append('some path')
> import more, stuff.
> ```
>
This case is not handled. Maybe there's a config setting we can use to
turn this off, but otherwise we can blacklist files that depend on this
pattern using flake8's `per-file-ignores`.
Probably should have made it a bit more clear that the isort change is
not imminent or anything. Items 1-3 should land in the next week or two
and 4-5 are on a bit longer of a time frame. There will be time to make
sure it's done right.
_______________________________________________
dev-builds mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-builds
