On Thu, Jan 5, 2017, at 07:43 AM, polly.s...@gmail.com wrote: > Hello, > > This is my first post so sorry if I do anything inappropriate. Also > please let me know if I do!
Hi there! > I have been looking at netwerk because I am thinking of implementing DHCP > proxy auto-detect as described in bug 356831. There are some cpp files in > netwerk/test which don't seem to be compiled as they're not in the local > moz.build (e.g. TestCachPrefixKeyParser.cpp), and I wondered if they > should be removed? There is a bug that I thought might be relevant: If they're not even listed in moz.build then they're not doing anything but wasting people's time showing up in code search results. We should definitely remove them! > https://bugzilla.mozilla.org/show_bug.cgi?id=1313752 > > However I didn't comment on that bug as it is marked as resolved, and > reading the etiquette guidelines, I thought it seemed as though I should > post here if unsure as to whether to comment. It's not out of the ordinary to comment on a closed bug to note that something was missing from the patch that landed, but it's also not the most useful because not everyone pays attention to closed bugs. We do sometimes reopen bugs, usually if the patch gets backed out because it was broken in some significant way. In this case this is just something that the developer missed, so the usual workflow would be to file a new bug and put the original bug in the new bug's "depends on" field. That way people following the original bug can get a bugzilla notification, but we've got a fresh bug to ensure the issue doesn't get lost in the shuffle. I'd recommend filing a new bug in Core: Networking, making it depend on bug 1313752 and CCing the original patch author (benja...@smedbergs.us). If any of that is confusing I'm happy to help (I sometimes forget how overwhelming Bugzilla can be to people who haven't developed Stockholm syndrome with it can be). If you need any additional help with your netwerk changes feel free to drop into irc.mozilla.org! #introduction has beginner-friendly help, #developers has lots of Gecko developers, and #necko has lots of network developers. Regards, -Ted _______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
