On 24/10/16 02:40 PM, Jack Bates wrote:
On 17/10/16 11:02 AM, Gregory Szorc wrote:
On Sat, Oct 15, 2016 at 1:28 PM, Jack Bates <tzm...@nottheoilrig.com
<mailto:tzm...@nottheoilrig.com>> wrote:
What do you think about making the
mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/libnssutil3.so
symlink relative vs. absolute?
When I follow these instructions [1] to build Firefox, I get the
following error:
> $ ./mach run
> [...]
> XPCOMGlueLoad error for file
.../mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/libnssutil3.so:
>
.../mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/libnssutil3.so:
cannot open shared object file: No such file or directory
> $
mozilla-central/obj-x86_64-pc-linux-gnu/dist/bin/libnssutil3.so is a
symlink to
mozilla-central/obj-x86_64-pc-linux-gnu/dist/lib/libnssutil3.so, but
the symlink is absolute, so if I move the source tree to another
path, I get the error above.
Could these symlinks be made relative vs. absolute?
They probably could be. But it is a lot of work and isn't a high
priority since very few people bring up this issue.
Here's a rough patch for turning the absolute symlinks into relative
ones. It works on my machine and resolves the issue above.
Would you be willing to take a look?
Are there any larger issues that I haven't considered?
If not, would you be willing to help me polish it into something that
could be accepted?
To move this forward, I submitted a review request [1] and picked gps as
the reviewer. If it shouldn't move forward, or there's a better choice
of reviewer, just let me know.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1316735
_______________________________________________
dev-builds mailing list
dev-builds@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-builds
