with esr38.1 on SunOS i386 using sun ld I came across an issue with the check 
for NSModules
refptr seems to be useful only with gnu ld.

I believe the following patch should do what is expected for both native and 
gnu ld/nm

> --- toolkit/library/libxul.mk.orig    2015-06-24 21:28:03.000000000 +0000
> +++ toolkit/library/libxul.mk
> @@ -55,7 +55,7 @@ endif
>  ifdef _MSC_VER
>  get_first_and_last = dumpbin -exports $1 | grep _NSModule@@ | sort -k 3 | 
> sed -n 's/^.*?\([^@]*\)@@.*$$/\1/;1p;$$p'
>  else
> -get_first_and_last = $(TOOLCHAIN_PREFIX)nm -g $1 | grep _NSModule$$ | grep 
> -vw refptr | sort | sed -n 's/^.* _*\([^ ]*\)$$/\1/;1p;$$p'
> +get_first_and_last = $(TOOLCHAIN_PREFIX)nm -Pgv $1 | grep _NSModule | egrep 
> 'start|end' | cut -f1 -d' '
>  endif
>  
>  LOCAL_CHECKS = test "$$($(get_first_and_last) | xargs echo)" != 
> "start_kPStaticModules_NSModule end_kPStaticModules_NSModule" && echo 
> "NSModules are not ordered appropriately" && exit 1 || exit 0
_______________________________________________
dev-builds mailing list
dev-builds@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-builds

Reply via email to