It seems that a flurry of new errors are introduced to make tests of
|make mozmill| fail.

I noticed this with my local test of locally build DEBUG BUILD version
of TB running |make mozmill|.

But this is also observed in TBPL: e.g., I pick up the
log from a job there:
https://tbpl.mozilla.org/php/getParsedLog.php?id=50404328&tree=Thunderbird-Trunk&full=1

 ....
TEST-UNEXPECTED-FAIL |
/builds/slave/test/build/mozmill/folder-display/test-selection.js |
test-selection.js::test_selection_extension
TEST-START |
/builds/slave/test/build/mozmill/folder-display/test-selection.js |
test_selection_last_message_deleted
Test Failure: aController.dbView.selection is null
 ....

There are a whole series of tests that fail to the same
aController.dbView.selection is null
error, and many more with different errors.

BTW, in the last three days, my local DEBUG BUILD needed to have the
following local patch because three variables lack proper declarations.
In the test log, JS complained loud and clear for the
missing declarations for the variables, and TB would not even start to
run when I tried to run it from the console. (I am afraid |make mozmill|
talked to the backend via XPCOM and never realized that there is
something wrong during the startup that failed to draw the screen
correctly).
With my patch of introducing the declarations, the above test
test_selection_last_message_deleted
resulted in MOZ_ASSERT() error ending in a crash with stack trace.

So something has gone wrong in C-C tree.

I suspect XUL or tree code changes in M-C may have triggered these
errors, but at least two of the variables missing declarations sound
very much T-B specific.
Does anyone have an idea what are causing the errors???

# HG changeset patch
# Parent 06b9b65bc27918092c72521e692593661a2c1783
# User ISHIKAWA, Chiaki <ishik...@yk.rim.or.jp>
add three missing declarations

diff --git a/mail/base/content/mail3PaneWindowCommands.js
b/mail/base/content/mail3PaneWindowCommands.js
--- a/mail/base/content/mail3PaneWindowCommands.js
+++ b/mail/base/content/mail3PaneWindowCommands.js
@@ -7,16 +7,20 @@
  * consisting of folder pane, thread pane and message pane.
  */

 Components.utils.import("resource:///modules/mailServices.js");
 Components.utils.import("resource:///modules/MailUtils.js");
 Components.utils.import("resource://gre/modules/Services.jsm");
 Components.utils.import("resource://gre/modules/PluralForm.jsm");

+var  gFolderDisplay;           // missing declaration as of Oct, 2014
+var  MailOfflineMgr;           // ditto
+var  accountManager;           // ditto
+
 // Controller object for folder pane
 var FolderPaneController =
 {
   supportsCommand: function(command)
   {
     switch ( command )
     {
       case "cmd_delete":
_______________________________________________
dev-builds mailing list
dev-builds@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-builds

Reply via email to