Hello AndreK, or anyone else affected,

Accepted ubuntu-drivers-common into oracular-proposed. The package will
build now and be available at
https://launchpad.net/ubuntu/+source/ubuntu-drivers-common/1:0.9.7.12 in
a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
oracular to verification-done-oracular. If it does not fix the bug for
you, please add a comment stating that, and change the tag to
verification-failed-oracular. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-drivers-common (Ubuntu Oracular)
       Status: Confirmed => Fix Committed

** Tags added: verification-needed verification-needed-oracular

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to ubuntu-drivers-common in Ubuntu.
https://bugs.launchpad.net/bugs/2092601

Title:
  ubuntu-drivers list  - Extremely slow

Status in ubuntu-drivers-common package in Ubuntu:
  Fix Released
Status in ubuntu-drivers-common source package in Oracular:
  Fix Committed
Status in ubuntu-drivers-common source package in Plucky:
  Fix Released

Bug description:
  [Impact]
  Some basic operations on ubuntu-drivers are extremely slow (> 1mn) and 
CPU-intensive, to the point that users might think it broken.

  Examples of such operations are
  ubuntu-drivers list
  ubuntu-drivers list-oem

  Both of those operations are used in subiquity. While the performance
  hit there might not be too noticeable due to parallelism with other
  steps of the install, it's still fairly bad.

  And of course users of both the ubuntu-drivers CLI and the software-
  properties panel GUI feel the impact in full.

  
  [Expected result]
  ubuntu-drivers takes seconds to run, not minutes.

  
  [Steps to reproduce]
  1. Run 'time ubuntu-drivers list' several times
  2. observe the time

  
  [Proposed fix]

  https://github.com/canonical/ubuntu-drivers-common/pull/116

  There is an issue when trying to compute a stable key to cache the
  results of a costly computation (modalias mapping), resulting in a
  write-only cache.

  The fix is to remove the cache entirely, expose the computation method
  as a new public API, and let the caller optionally provide the
  previously cached value.

  
  [Test plan]
  1. Run 'time ubuntu-drivers list' several times
  the test should take mere seconds instead of tens of seconds or even minutes


  [Where problems could occur]
  Regression risks are minimal: for all the use cases listed above, the call 
sites are within ubuntu-drivers-common and have been inspected for correctness 
of hoisting the modalias mapping out of the loop. Any other caller of the 
changed API doesn't need to be changed as the new argument is optional. The 
removal of the cache is essentially a NOP since cached values weren't retrieved 
anyway due to the original bug.



  
  [Original report]
  Looking for drivers is extremely slow.
  Verified to exist on multiple systems.

  ----------------
  $ time ubuntu-drivers list
  nvidia-driver-560-open, (kernel modules provided by 
linux-modules-nvidia-560-open-generic-hwe-24.04)
  nvidia-driver-560, (kernel modules provided by 
linux-modules-nvidia-560-generic-hwe-24.04)

  real  1m48.680s
  user  0m26.984s
  sys   1m21.665s
  ----------------

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/2092601/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to