The test plan was executed for Noble (24.04) and I confirm it was successful.
The package version used for the tests is the one proposed, as can be seen by
the output of apt-cache policy:
adsys:
Installed: 0.14.2~24.04
Candidate: 0.14.2~24.04
Version table:
*** 0.14.2~24.04 500
500 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages
The following steps were executed:
1) Create a fresh VM with Ubuntu 24.04;
2) Join an active directory domain (created for test purposes);
3) Install adsys;
4) Authenticate with an AD user using the \\ format (e.g. domain.com\\user)
After step 4, the user was authenticated, the username format was
correctly parsed and all domain-related settings were applied.
** Tags removed: verification-needed-jammy verification-needed-noble
** Tags added: verification-done-jammy verification-done-noble
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to adsys in Ubuntu.
https://bugs.launchpad.net/bugs/2078247
Title:
rewrite from / to @ formats overwrites usernames
Status in adsys package in Ubuntu:
Fix Released
Status in adsys source package in Jammy:
Fix Committed
Status in adsys source package in Noble:
Fix Committed
Bug description:
tracking bug
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/2078245
[ Impact ]
In this code, the string was not zero terminated properly when
overwritten resulting in extra characters:
static char *slash_to_at_username(const char *username) {
char *backslash = strchr(username, '\\');
if (backslash != NULL) {
char *ret = malloc((strlen(username) + 1) * sizeof(char));
strcpy(ret, backslash + 1);
strcat(ret, "@");
strncpy(ret + strlen(ret), username, backslash - username);
return ret;
}
return strdup(username);
For instance:
domain.tld\\user was changed to [email protected]
So se user cannot login with the domain\user format
[ Test Plan ]
1. On a machine joined to an AD domain with ADsys installed, login
with domain\user
=> Without the patch the user cannot log in
=> With the patch the user can log in
[ Where problems could occur ]
Worst case the user still cannot log in
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/2078247/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
