Reading the description in the changelog did not tell me why this was
appropriate for SRU.

+    - Add support for force installing the NVIDIA driver on unsupported
+      devices. (lp: #1990341)

You can obviously force install nvidia drivers on any device by using
apt.

What this feature addition is actually about is allowing OEMs to locally
extend the mapping of PCI IDs to drivers in a custom image.  That's very
different than what I understood from the changelog.

Changelog entries for SRUs are much more visible to users than changelog
entries in devel, and while they will often be technical and not
understood by all users, I think it's important that they at least be
accurate.

I'm not rejecting this SRU, but I would like to see it reuploaded with a
clearer changelog entry.

** Changed in: ubuntu-drivers-common (Ubuntu Jammy)
       Status: Fix Committed => Incomplete

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to ubuntu-drivers-common in Ubuntu.
https://bugs.launchpad.net/bugs/1990341

Title:
  [SRU] Support to install nvidia driver by allowing list

Status in OEM Priority Project:
  Confirmed
Status in ubuntu-drivers-common package in Ubuntu:
  Fix Released
Status in ubuntu-drivers-common source package in Jammy:
  Incomplete
Status in ubuntu-drivers-common source package in Lunar:
  Fix Released

Bug description:
  [ Impact ]

   * In NVIDIA new GPU release cycle, NVIDIA ships their new GPUs to
  OEM/ODM for production.

  In the meantime, NVIDIA usually notify OEM/ODM/Canonical (under NDA)
  to use a specific nvidia version to development/production.

  NVIDIA and OEN/ODM will announce the next generation combination at
  the same time usually when the factory ready to ship the product.

  We made Ubuntu as a leading distribution supports many cutting edge
  devices, it's time to have an official way to make the nvidia
  installation consistent in unannounced (yet) nvidia devices to support
  OEM/ODM factory shipment for our growing counterparts.

  [ Test Plan ]

   * Steps to make sure it works:

  1. pick a cutting edge nvidia graphic.
  2. remove nv-525 from the pool by removing restricted in jammy-updates and 
jammy-security
  3. check the nv support status:
  ```
  $ ubuntu-drivers list
  oem-fix-gfx-nvidia-ondemandmode
  libfprint-2-tod1-broadcom
  oem-somerville-cinccino-meta
  ```
  4. modify custom file
  ```
  $ cat /etc/custom_supported_gpus.json
  {
    "chips": [
      {
        "devid": "0x24BA",
        "name": "TEST 24BA",
        "branch": "580.1234",
        "features": [
          "runtimepm"
        ]
      },
      {
        "devid": "0x25BC",
        "name": "TEST 25BC",
        "branch": "510",
        "features": [
          "runtimepm"
        ]
      }
    ]
  }
  ```
  5. make sure the hook works
  ```
  $ ubuntu-drivers list
  nvidia-driver-510, (kernel modules provided by nvidia-dkms-510)
  oem-fix-gfx-nvidia-ondemandmode
  libfprint-2-tod1-broadcom
  oem-somerville-cinccino-meta

  [ Where problems could occur ]

   * This feature only impact target system has a custom file
  "/etc/custom_supported_gpus.json". And it won't generate automatically
  which should not impact normal users

  [ Other Info ]

   * the patches are picked from
     - 
https://github.com/tseliot/ubuntu-drivers-common/commit/ec675fba22c68932da9fae95e0f4f2fd10732bf3
     - 
https://github.com/tseliot/ubuntu-drivers-common/commit/4776c6b9f78411ef3b269a28e9546e4ffd2b7115
     - 
https://github.com/tseliot/ubuntu-drivers-common/commit/83528313da84b55c04daa62b5edcbf823e5c067b.
   * Discussion is in https://github.com/tseliot/ubuntu-drivers-common/pull/71

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1990341/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to