Robie, thank you for taking the time to review this proposed stable release update. Let me try to provide more justification for this proposed update.
Yes, I am treating this as a microrelease update which according to my understanding will not require specific bug reports and verification for each patch but just an overall test case for the update. The GNOME Remote Desktop maintainer has strongly and repeatedly urged distros to take the freerdp2 2.7.0 release. GNOME 42 is the first GNOME release to offer RDP Sharing and there are several bugfixes and crashes fixed in the new freerdp2 version. Since GNOME Remote Desktop sharing is the primary usecase for freerdp2 in Ubuntu 22.04 LTS, I think the opinion of the upstream maintainers carries some weight here. The secondary usecase is the remote desktop client Remmina so that's why the manual test plan tests that feature too. To try to minimize the change needed for this SRU, we cherry-picked 23 non-changelog commits from 2.7.0 to Ubuntu 22.04 LTS already. This proposed SRU adds the 8 remaining commits. I believe that for users seeking support upstream, it will be easier if they can report that they are using 2.7.0 rather than effectively a git snapshot especially since the git snapshot isn't obvious from the Ubuntu version number (you'd have to read debian/changelog to know this). I understand that the packaging update is really noisy because of so many patches dropped. Therefore, I am attaching a diff of the code change now for the patched source (excluding the debian/ directory). Or you can browse the git commit log linked in the bug description for commits after April 11. The 2.7.0 update is an update from freerdp2's stable branch. The changes are all limited backports from the main trunk development branch. The final change is backporting another patch set (from the stable branch after the 2.7.0 release). That change is difficult to verify with our usual SRU procedures. It fixes a crash that we don't know how to reliably reproduce. The easiest verification that the patch works is to monitor errors.ubuntu.com to make sure that the crash reports stop. But you can't really do that until the updated version is pushed to jammy- updates, right? ** Patch added: "lp1973229-unpacked-without-debian.diff" https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/1973229/+attachment/5591634/+files/lp1973229-unpacked-without-debian.diff ** Changed in: freerdp2 (Ubuntu Jammy) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to freerdp2 in Ubuntu. https://bugs.launchpad.net/bugs/1973229 Title: Update freerdp2 to 2.7.0 Status in freerdp2 package in Ubuntu: Fix Released Status in freerdp2 source package in Jammy: In Progress Bug description: Impact ------ Ubuntu 22.04 LTS includes basically a git snapshot of freerdp2 as of April 11. freerdp 2.7.0 was released April 25 with a few more bug fixes. https://github.com/FreeRDP/FreeRDP/commits/stable-2.0?after=f8a4c6a9fed51cacd7b75ca95e2fcb018f4ac5b8+46&branch=stable-2.0 From the NEWS file, the changes are * Backported OpenSSL3 gateway support (#7822) * Backported #7733: Support 10bit X11 color (BGRX32 only) * Backported #7808: Disable websockets with /gt:rpc * Backported #7815: RAIL expect LOGON_MSG_SESSION_CONTINUE Also, this includes patches that the upstream gnome-remote-desktop maintainers believe fix LP: #1970994 I am not mentioning that bug number in the debian/changelog because I don't have a clear test case to reproduce that bug, which is needed for SRU verification to go smoothly. Test Case #1 ------------ Install all updates. Log out and log back in. Open the Settings app to the Sharing page. Turn on Sharing and turn on Remote Desktop Sharing. Turn it off then on because there may be a gnome-control-center bug with initial enabling. From a second computer, connect to the first computer using Remmina. The Remote Desktop page on the first computer provides the username and password to use. I wasn't able to get the "Remote Desktop Address" to work (maybe avahi doesn't work well?) so just use the first computer's IP address. So something like: RDP jeremy@192.168.1.1 Ensure that the connection works. Then repeat the test after updating the second computer to use the updated freerdp2 since Remmina itself uses freerdp2. Basically we want to make sure things keep working after the update but also continue to work for connections between systems that aren't using the same version of freerdp2. What Could Go Wrong ------------------- RDP Sharing using freerdp2 is a new feature for Ubuntu 22.04 LTS as part of GNOME 42. RDP Sharing can be used for providing remote support so it's important that this feature works well because it may be difficult for the remote admin to fix issues in person. freerdp2 is also used by the Remmina and GNOME Connections apps as the "client" app for RDP Sharing. (The GNOME feature is the "server" side.) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/1973229/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
