New debdiff in attach that relies on CONFIG_ACPI to determine if we need to check the power state in bbswitch_off().
** Patch added: "bbswitch-fix-build-error-when-acpi-is-not-available.debdiff" https://bugs.launchpad.net/ubuntu/+source/bbswitch/+bug/1951583/+attachment/5544007/+files/bbswitch-fix-build-error-when-acpi-is-not-available.debdiff -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to bbswitch in Ubuntu. https://bugs.launchpad.net/bugs/1951583 Title: bbswitch dkms build failure with 5.15 on armhf and ppc64el Status in bbswitch package in Ubuntu: New Status in bbswitch source package in Jammy: New Bug description: [Impact] bbswitch is failing to build with the latest jammy kernel 5.15 on armhf and ppc64el. The build error that we get looks like the following: CC [M] /var/lib/dkms/bbswitch/0.8/build/bbswitch.o /var/lib/dkms/bbswitch/0.8/build/bbswitch.c: In function ‘bbswitch_off’: /var/lib/dkms/bbswitch/0.8/build/bbswitch.c:271:13: error: implicit declaration of function ‘acpi_bus_get_device’; did you mean ‘acpi_get_gpe_device’? [-Werror=implicit-function-declaration] 271 | r = acpi_bus_get_device(dis_handle, &ad); | ^~~~~~~~~~~~~~~~~~~ | acpi_get_gpe_device /var/lib/dkms/bbswitch/0.8/build/bbswitch.c:276:15: error: invalid use of undefined type ‘struct acpi_device’ 276 | if (ad->power.state == ACPI_STATE_UNKNOWN) { | ^~ /var/lib/dkms/bbswitch/0.8/build/bbswitch.c:278:15: error: invalid use of undefined type ‘struct acpi_device’ 278 | ad->power.state = ACPI_STATE_D0; | ^~ [Test case] Install bbswitch-dkms. [Fix] It looks like bbswitch is using acpi_bus_get_device() on any architectures to check for suspend events, but this function is not available on armhf or ppc64el. The fix would be to avoid doing this check (and using acpi_bus_get_device()) on architectures that don't have this capability. [Regression potential] We should see potential bbswitch regressions on armhf or ppc64el if they have suspend events (similar problem that is addressed on amd64 / arm64). To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/bbswitch/+bug/1951583/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
