Launchpad has imported 15 comments from the remote bug at
https://bugs.webkit.org/show_bug.cgi?id=171770.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2017-05-06T10:56:10+00:00 Jiří Janoušek wrote:

Hello. I cannot sign-in to Google services since it introduced a new
sign-in page.

Steps to reproduce:

1. Open a WebKitGTK browser.
2. Visit https://google.com
3. Click sign-in button in the top right corner.
4. Type e-mail and click Next.
5. Enter password and click Next.

Expected result:

- Google asks for a pin from two-factor authentication. (It does so in
Firefox 52 and Chromium 58.)

Actual result:

- An empty page is loaded 
(https://accounts.google.com/signin/v2/challenge/password/empty).
- There is no error in the JavaScript console.

Clients:

Epiphany 3.22.6, WebKitGTK+ 2.14.6
MiniBrowser, WebKitGTK+ 2.16.1

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/26

------------------------------------------------------------------------
On 2017-05-06T11:03:14+00:00 Cgarcia-f wrote:

(In reply to Jiří Janoušek from comment #0)
> Hello. I cannot sign-in to Google services since it introduced a new sign-in
> page.
> 
> Steps to reproduce:
> 
> 1. Open a WebKitGTK browser.
> 2. Visit https://google.com
> 3. Click sign-in button in the top right corner.
> 4. Type e-mail and click Next.
> 5. Enter password and click Next.
> 
> Expected result:
> 
> - Google asks for a pin from two-factor authentication. (It does so in
> Firefox 52 and Chromium 58.)
> 
> Actual result:
> 
> - An empty page is loaded
> (https://accounts.google.com/signin/v2/challenge/password/empty).
> - There is no error in the JavaScript console.
> 
> Clients:
> 
> Epiphany 3.22.6, WebKitGTK+ 2.14.6
> MiniBrowser, WebKitGTK+ 2.16.1

Empty page with current trunk too

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/27

------------------------------------------------------------------------
On 2017-05-06T13:52:05+00:00 Michael Catanzaro wrote:

OK, I can reproduce. Problem is the server is sending us a completely
blank. So... I don't even know where to start trying to debug this.
Historically, we have had zero luck trying to get Google to fix any of
their many bugs affecting WebKit, so this is going to be a big problem.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/28

------------------------------------------------------------------------
On 2017-05-06T13:53:12+00:00 Michael Catanzaro wrote:

(In reply to Michael Catanzaro from comment #2)
> OK, I can reproduce. Problem is the server is sending us a completely blank.

a completely blank page. Not even HTML body tags or even a single
character.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/29

------------------------------------------------------------------------
On 2017-05-06T14:03:17+00:00 Michael Catanzaro wrote:

The Firefox UA quirk breaks the login page.

This is unmanageable. I'm at wits end. We are going to have to base our
Google user agent quirks on the path component of the URI.

I'm really at a loss for words as to how horrible this is.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/30

------------------------------------------------------------------------
On 2017-05-06T14:41:04+00:00 Michael Catanzaro wrote:

You know, if we're very lucky, we *might* be able to get away with doing
this:

static bool urlRequiresFirefoxBrowser(const URL& url)
{
    return isGoogle(url) && url.host() != "accounts.google.com";
}

That's probably not very likely to work, but if it works, then we're
saved. At any rate, just removing the Firefox quirk and leaving Calendar
and Maps/Earth broken is not acceptable.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/31

------------------------------------------------------------------------
On 2017-05-06T17:19:17+00:00 Jiří Janoušek wrote:

> a completely blank page. Not even HTML body tags or even a single
character.

Looking at Firefox's web inspector, Google sends the same to Firefox
too, but then there is XHR POST request to
https://accounts.google.com/signin/v2/challenge/totp and this is URL
eventually appears in the URL bar. No idea how, it's just magic.

> The Firefox UA quirk breaks the login page.

Indeed, I've set "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/604.1
(KHTML, like Gecko) Version/11.0 Safari/604.1" as the user agent string
in my Nuvola app for Google Play Music and it works. Does
WebKitSettings:enable_site_specific_quirks affect anything else than an
user agent string?

Is there any public API to set a different user agent per request? It
would be convenient if I could modify user agent quirks without a need
to wait for a next WebKitGTK release.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/32

------------------------------------------------------------------------
On 2017-05-06T21:00:54+00:00 Michael Catanzaro wrote:

(In reply to Jiří Janoušek from comment #6)
> Does
> WebKitSettings:enable_site_specific_quirks affect anything else than an user
> agent string?

Yes, turning that off is going to break other websites. I'm not sure off
the top of my head which, but I think there are maybe layout or some
other sort of quirks for YouTube.

> Is there any public API to set a different user agent per request? It would
> be convenient if I could modify user agent quirks without a need to wait for
> a next WebKitGTK release.

No, sorry, the only way is to disable site specific quirks. We will make
a release ASAP, since this is an emergency.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/33

------------------------------------------------------------------------
On 2017-05-06T23:29:21+00:00 Michael Catanzaro wrote:

(In reply to Michael Catanzaro from comment #5)
> You know, if we're very lucky, we *might* be able to get away with doing
> this:

It works, rejoice.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/34

------------------------------------------------------------------------
On 2017-05-06T23:34:58+00:00 Michael Catanzaro wrote:

Created attachment 309305
Patch

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/35

------------------------------------------------------------------------
On 2017-05-07T09:01:42+00:00 Cgarcia-f wrote:

Comment on attachment 309305
Patch

I'm r+ and cq+'ing because this is important fix, but it should include
a unit tests, please add it in a follow up patch. Thanks for fixing this
mess

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/36

------------------------------------------------------------------------
On 2017-05-07T09:29:48+00:00 Commit-queue wrote:

Comment on attachment 309305
Patch

Clearing flags on attachment: 309305

Committed r216343: <http://trac.webkit.org/changeset/216343>

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/38

------------------------------------------------------------------------
On 2017-05-07T09:29:50+00:00 Commit-queue wrote:

All reviewed patches have been landed.  Closing bug.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/39

------------------------------------------------------------------------
On 2017-05-07T19:40:05+00:00 Michael Catanzaro wrote:

*** Bug 171793 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/40

------------------------------------------------------------------------
On 2017-05-07T19:59:45+00:00 Michael Catanzaro wrote:

Committed r216350: <http://trac.webkit.org/changeset/216350>

Reply at:
https://bugs.launchpad.net/ubuntu/+source/webkit2gtk/+bug/1687019/comments/41

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to webkit2gtk in Ubuntu.
https://bugs.launchpad.net/bugs/1687019

Title:
  Cannot add a Google account using Online Accounts in Ubuntu Gnome

Status in gnome-online-accounts:
  Unknown
Status in Ubuntu GNOME:
  Fix Released
Status in WebKit:
  Fix Released
Status in webkit2gtk package in Ubuntu:
  Fix Released
Status in webkit2gtk source package in Xenial:
  Fix Released
Status in webkit2gtk source package in Yakkety:
  Fix Released
Status in webkit2gtk source package in Zesty:
  Fix Released
Status in webkit2gtk source package in Focal:
  Fix Released
Status in webkit2gtk package in Debian:
  Fix Released

Bug description:
  Impact
  -----
  Users will be unable to log in to a Google account using GNOME Online Account 
which is used by default in Ubuntu GNOME and Ubuntu Budgie.

  Any other browser or service that uses webkit2gtk is similarly broken,
  such as the Epiphany browser.

  The second issue fixed here is that any user who opted in to the new
  YouTube will only get a white screen when they attempt to visit
  YouTube. The new YouTube is still opt-in now but will eventually
  become the default for everyone.

  Test Case
  ---------
  1. Install the updated webkit2gtk on Ubuntu GNOME.
  2. Restart your computer (this may be necessary because of LP: #1610944)
  3. Log in. Open Settings>Online Accounts. Remove any Google accounts already 
configured. Add your Google account.
  4. Install Evolution if it's not already installed and verify that your Gmail 
account loads.

  Optional, because the beta is closed to new entrants:
  5. Install epiphany-browser
  6. Open the Web app (epiphany-browser) and log in to your Google account.
  7. Visit https://www.google.com/new to make sure that your browser is set to 
use the "new YouTube."
  8. If the new YouTube only shows a white screen, this part of the bug is not 
fixed.

  Regression Potential
  --------------------
  The regression potential was limited by only cherry-picking the commits to 
fix these 2 high-profile issues. 2.16.2 is being rolled out to most distros now.

  Other Info
  ----------
  Fixed in 17.10 Alpha "artful" by updating to 2.16.2

  Original Bug Report
  -------------------
  With Ubuntu Gnome 17.04 (brand new 64bit install on a Dell XPS13 laptop), I 
cannot add a Google account using Online-Accounts. If I choose to add a new 
Google account in Online Accounts, a window appears where I can enter my Google 
email. After entering my email and pressing the Next button, a window appears 
where I can enter my Google password. After entering the password and pressing 
the Next button, an empty window appears and nothing else happens. I expected 
this to show something useful, and actually add the Google account to my Gnome 
environment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/gnome-online-accounts/+bug/1687019/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to