Comment on attachment 394269 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394269&action=review
> Source/WTF/ChangeLog:11 > + will be even easier to detect if we change > RELEASE_ASSERT_WITH_MESSAGE() to actually print We should not change RELEASE_ALERT_WITH_MESSAGE() to unconditionally print its message. That message is only meant to be used in debug builds. But if you really want a message in a release build, you can always check the condition first and print your message before doing the RELEASE_ASSERT. I do not recommend doing this in the general case (for performance reasons), but in your implementation here, it’ll only be executed once. So checking and printing that error message won’t hurt much. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to webkit2gtk in Ubuntu. https://bugs.launchpad.net/bugs/1868108 Title: [autopkgtest][focal] ruby-gnome/3.4.1-2build1 class:TestWebKit2GtkWebView failure Status in Webkit: Fix Released Status in webkit2gtk package in Ubuntu: Fix Released Status in webkit2gtk source package in Focal: Fix Released Bug description: ruby-gnome/3.4.1-2* package fails with: -------------------------------------------------------------------------------- 2020-03-19T13:29:50+00:00: Running test for /tmp/autopkgtest.2iRDtE/build.GH8/src/webkit2-gtk -------------------------------------------------------------------------------- Loaded suite test Started (run-test.rb:9142): dbind-WARNING **: 13:29:51.769: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files ..[2020-03-19 13:29:52] INFO WEBrick 1.6.0 [2020-03-19 13:29:52] INFO ruby 2.7.0 (2019-12-25) [powerpc64le-linux-gnu] [2020-03-19 13:29:52] INFO WEBrick::HTTPServer#start: pid=9142 port=37651 (WebKitWebProcess:9153): dbind-WARNING **: 13:29:52.607: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files F =============================================================================== Failure: test: #load_uri(TestWebKit2GtkWebView::#load_uri): <true> expected but was <false> /tmp/autopkgtest.2iRDtE/build.GH8/src/webkit2-gtk/test/test-webkit2-gtk-web-view.rb:106:in `block (2 levels) in <class:TestWebKit2GtkWebView>' 103: @view.load_uri(http_url) 104: loop.run 105: => 106: assert_true(loaded) 107: end 108: end 109: end ===============================================================================[2020-03-19 13:30:22] INFO going to shutdown ... [2020-03-19 13:30:22] INFO WEBrick::HTTPServer#start done. ...... Finished in 30.95292437 seconds. ------------------------------------------------------------------------------- 9 tests, 9 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.8889% passed ------------------------------------------------------------------------------- 0.29 tests/s, 0.29 assertions/s Failed to run test: webkit2-gtk -------------------------------------------------------------------------------- Failed targets: webkit2-gtk Gdk-Message: 13:30:22.622: WebKitWebProcess: Fatal IO error 2 (No such file or directory) on X server :99. autopkgtest [13:30:22]: test run-test: -----------------------] run-test FAIL non-zero exit status 1 autopkgtest [13:30:23]: test run-test: - - - - - - - - - - results - - - - - - - - - - autopkgtest [13:30:23]: @@@@@@@@@@@@@@@@@@@@ summary run-test FAIL non-zero exit status 1 Exit request sent. When running in ppc64el. This is likely due a timeout in glib main loop for that architecture but can't know for sure. I'm opening this bug so I can blacklist that particular test. To manage notifications about this bug go to: https://bugs.launchpad.net/webkit/+bug/1868108/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
