Comment on attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.

https://reviewboard.mozilla.org/r/225184/#review231212

::: modules/libpref/Preferences.cpp:3982
(Diff revision 1)
> -    Preferences::GetCString(kChannelPref, updateChannelPrefValue,
> -                            PrefValueKind::Default);
> +    Preferences::GetCString(
> +      kChannelPref, updateChannelPrefValue, PrefValueKind::Default);
>      releaseCandidateOnBeta = updateChannelPrefValue.EqualsLiteral("beta");
>    }
>  
>    if (!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "nightly") ||
>        !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "aurora") ||
> -      !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") ||
> +      !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") || developerBuild ||

clang-format changed its mind, I guess?

::: modules/libpref/parser/src/lib.rs:282
(Diff revision 1)
>  struct KeywordInfo {
>    string: &'static [u8],
>    token: Token,
>  }
>  
> -const KEYWORD_INFOS: &[KeywordInfo; 5] = &[
> +const KEYWORD_INFOS: &[KeywordInfo; 7] = &[

In passing, AFAIK, this could actually me [KeywordInfo; 7] (without the
ref)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951

Title:
  Firefox 3.6 does not honour lockPref

Status in Mozilla Firefox:
  Fix Released
Status in firefox package in Ubuntu:
  Fix Released

Bug description:
  Binary package hint: firefox

  In firefox 3.5 the following worked:
  Set
  lockPref("network.proxy.type", 5);
  in /etc/firefox-3.5/pref/firefox.js

  Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
  not lock down the proxy.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to