Comment on attachment 8390075
patch v6 - local folders
Review of attachment 8390075:
-----------------------------------------------------------------
::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +3843,5 @@
>
> +nsresult
> +nsMsgDBFolder::ConfirmAutoFolderRename(nsIMsgWindow *msgWindow,
> + const nsString aOldName,
> + const nsString aNewName,
These should be const nsString &... to avoid unnecessary string copies.
@@ +3846,5 @@
> + const nsString aOldName,
> + const nsString aNewName,
> + bool *confirmed)
> +{
> + NS_ENSURE_ARG_POINTER(confirmed);
It is possible that confirmed never gets set, so you might then end up
with a bad value.
Additionally I don't really see the point of returning nsresult here,
when you're already warning for errors, and you treat a failure as not
confirmed anyway.
So I think it would be simpler just to change this function to return
the bool.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the same
name
Status in Mozilla Thunderbird Mail and News:
In Progress
Status in “thunderbird” package in Ubuntu:
Triaged
Bug description:
Binary package hint: mozilla-thunderbird
1. Create a new folder, eg. "Temp"
2. Delete it, OK
3. Create the same folder again
4. Delete it, OK
I expect it to be moved to my Trash folder, perhaps with a suffix
appended (it being the second instance of that folder in the trash).
Thunderbird popped up an error message. On an imap host:
The current command did not succeed. The mail server responded: Mailbox
already exists.
In the local folders:
A folder with that name already exists. Please enter a different name (!)
Workarounds:
1. Empty the trash
2. Rename the folder before deletion
3. Rename the folder already in the trash
4. Delete (permanently) the folder that is already in the trash
Ubuntu 7.10 Gutsy
thunderbird 2.0.0.12+nobinonly-0ubuntu0.7.10.0
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
