Thank you. I updated the bug description.

** Description changed:

- wayland-protocols on Noble is version 1.45 which reports the value for `blur` 
as 0. But 0 was a mistake and the correct value should've been 1. 
+ wayland-protocols on Noble is version 1.45 which reports the value for
+ `blur` as 0. But 0 was a mistake and the correct value should've been 1.
+ 
+ [impact]
+ - Applications compiled on noble will expect the compositor to advertise blur 
support with "0", but any compositor that supports background-effect will 
advertise it as "1". So, the application won't blur and will just be 
transparent.
+ 
+ [test plan]
+ - compile foot terminal on nobel
+ ```
+ git clone https://codeberg.org/dnkl/foot.git
+ cd foot
+ meson setup build --buildtype=release
+ meson compile -C build
+ sudo meson install -C build
+ ```
+ Then if you run this on a compositor that supports blur (like kde, 
hyprland,...):
+ ```
+ foot --log-level=debug 2>&1 | grep 'background blur'
+ ```
+ should return "yes".
+ 
+ [Where problems could occur]
+ - if other files are modified it could break other applications. The fix 
should only change this one character from 0 to 1.
+ - Per the upstream commit message, this is technically
+  an ABI change but cannot cause regressions because the broken value made the
+  capability unusable: "the client could never receive the blur capability
+  before this commit, it won't actually break anything - it was already 
broken."
+ 
+ [other info]
  Here's the upstream commit:
  
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/commit/efbc060534be948b63e1f395d69b583eebba3235
- 
- Probably a point release fixing this bug is necessary since Noble is
- LTS.
  
  I noticed the issue when trying to get blur working in comsic-comp:
  https://github.com/pop-os/cosmic-comp/pull/2179#issuecomment-4158677468
  
  
  I've never reported a bug on launchpad. So, forgive me if I'm doing it wrong.

** Description changed:

  wayland-protocols on Noble is version 1.45 which reports the value for
  `blur` as 0. But 0 was a mistake and the correct value should've been 1.
  
  [impact]
  - Applications compiled on noble will expect the compositor to advertise blur 
support with "0", but any compositor that supports background-effect will 
advertise it as "1". So, the application won't blur and will just be 
transparent.
  
  [test plan]
  - compile foot terminal on nobel
  ```
  git clone https://codeberg.org/dnkl/foot.git
  cd foot
  meson setup build --buildtype=release
  meson compile -C build
  sudo meson install -C build
  ```
  Then if you run this on a compositor that supports blur (like kde, 
hyprland,...):
  ```
  foot --log-level=debug 2>&1 | grep 'background blur'
  ```
  should return "yes".
  
  [Where problems could occur]
  - if other files are modified it could break other applications. The fix 
should only change this one character from 0 to 1.
- - Per the upstream commit message, this is technically
-  an ABI change but cannot cause regressions because the broken value made the
-  capability unusable: "the client could never receive the blur capability
-  before this commit, it won't actually break anything - it was already 
broken."
+ - Per the upstream commit message, this is technically an ABI change but 
cannot cause regressions because the broken value made the capability unusable: 
"the client could never receive the blur capability before this commit, it 
won't actually break anything - it was already broken."
  
  [other info]
  Here's the upstream commit:
  
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/commit/efbc060534be948b63e1f395d69b583eebba3235
  
  I noticed the issue when trying to get blur working in comsic-comp:
  https://github.com/pop-os/cosmic-comp/pull/2179#issuecomment-4158677468
  
- 
- I've never reported a bug on launchpad. So, forgive me if I'm doing it wrong.
+ I've never reported a bug on launchpad. So, forgive me if I'm doing it
+ wrong.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to wayland-protocols in Ubuntu.
https://bugs.launchpad.net/bugs/2146947

Title:
  wayland-protocols in noble has the wrong value for blur

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wayland-protocols/+bug/2146947/+subscriptions


-- 
desktop-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to