Agree, having this working in SE envs would be nice. This is the data container which is related to the currently executed query [1]. The main reason for making this request scope injectable was the usage for base DAOs or if a client wants to add its own DAO code - here [2] the call gets delegated to a concrete implementation.
Passing the query context data into CDI Query controlled code is not really a problem, for client code having something injectable seemed to me the most elegant solution. But there are certainly other variants in order to get rid of the request scope (e.g. having a contract on the DelegateQueryHandler interface - open for other suggestions). [1] https://github.com/ctpconsulting/query/blob/deltaspike/impl/src/main/java/com/ctp/cdi/query/handler/CdiQueryInvocationContext.java [2] https://github.com/ctpconsulting/query/blob/deltaspike/impl/src/main/java/com/ctp/cdi/query/builder/DelegateQueryBuilder.java On Sun, Mar 3, 2013 at 1:41 PM, Romain Manni-Bucau <[email protected]>wrote: > Basically if the query logic could be scope agnostic it would be perfect > for me. Parameters were fine and matched the coomon need. I m not sure i > get what is blocking. Can you detail it a bit please? > Le 3 mars 2013 13:09, "Thomas Hug" <[email protected]> a > écrit : > > > Aha got you. Yes QueryHandler can be moved to application scope. > > > > The other request scoped component ist the CdiQueryInvocationContext. > Here > > we store a bunch of data which is related to the current query > (parameters, > > query string etc). Originally this was passed as parameter, but got > > injectable for the extension mechanism [1]. Currently on holidays (sorry > > the response delays) so not much time to look into it but happy to take > > suggestions :) > > > > [1] > > > > > http://ctpconsulting.github.com/query/1.0.0.Alpha5/extensions.html#extension-delegates > > > > On Fri, Mar 1, 2013 at 8:18 PM, Romain Manni-Bucau < > [email protected] > > >wrote: > > > > > Hmm, > > > > > > Wonder if the scope couldnt be application one. Request sounds too much > > web > > > to be usable/generic > > > Le 1 mars 2013 19:02, "Thomas Hug" <[email protected]> a > > > écrit : > > > > > > > Fine for me - planned to create a branch with all the experimental > APIs > > > > cleared out as an import proposal. > > > > > > > > RE scope, the InvocationHandlers are validated to be normal scoped > [1], > > > so > > > > that seemed to me the most appropriate choice - any other > suggestions? > > > > > > > > [1] > > > > > > > > > > > > > > https://github.com/DeltaSpike/Mirror/blob/master/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/invocationhandler/InvocationHandlerBindingExtension.java#L198 > > > > > > > > > > > > On Wed, Feb 27, 2013 at 1:15 PM, Romain Manni-Bucau > > > > <[email protected]>wrote: > > > > > > > > > Hi, > > > > > > > > > > some news of it? > > > > > > > > > > i think it is time to import at least a first version, isn't it? > > > > > > > > > > Just a note on current code, i saw QueryHandler (and some other > > beans) > > > > has > > > > > a request scope. Wonder if such a scope means something for a > generic > > > > (not > > > > > web) lib. > > > > > > > > > > wdyt? > > > > > > > > > > *Romain Manni-Bucau* > > > > > *Twitter: @rmannibucau <https://twitter.com/rmannibucau>* > > > > > *Blog: **http://rmannibucau.wordpress.com/*< > > > > > http://rmannibucau.wordpress.com/> > > > > > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > > > > > *Github: https://github.com/rmannibucau* > > > > > > > > > > > > > > > > > > > > 2013/2/20 Romain Manni-Bucau <[email protected]> > > > > > > > > > > > guy you rocks! > > > > > > > > > > > > effectively i missed it when i looked. > > > > > > > > > > > > *Romain Manni-Bucau* > > > > > > *Twitter: @rmannibucau <https://twitter.com/rmannibucau>* > > > > > > *Blog: **http://rmannibucau.wordpress.com/*< > > > > > http://rmannibucau.wordpress.com/> > > > > > > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > > > > > > *Github: https://github.com/rmannibucau* > > > > > > > > > > > > > > > > > > > > > > > > 2013/2/20 Thomas Hug <[email protected]> > > > > > > > > > > > >> Thnx Romain. If with proxy stuff you refer to the DS > > > > > >> InvocationHandlerBinding, that's already integrated :) > > > > > >> > > > > > >> RE pagination, it's maybe not that obvious, but there's more > > > advanced > > > > > >> support in QueryResult [1][2], which is more of a fluent API > > > approach, > > > > > but > > > > > >> should behave similar to a PageRequest (the query execution is > > > delayed > > > > > >> until the getResult() methods on QueryResult is called). Hope > that > > > > fits > > > > > to > > > > > >> what you had in mind. > > > > > >> > > > > > >> [1] > > > > > >> > > > > > >> > > > > > > > > > > > > > > > https://github.com/ctpconsulting/query/blob/deltaspike/api/src/main/java/com/ctp/cdi/query/QueryResult.java > > > > > >> [2] > > > > > >> > > > > > >> > > > > > > > > > > > > > > > https://github.com/ctpconsulting/query/blob/deltaspike/impl/src/test/java/com/ctp/cdi/query/QueryResultTest.java > > > > > >> > > > > > >> On Wed, Feb 20, 2013 at 10:04 PM, Romain Manni-Bucau > > > > > >> <[email protected]>wrote: > > > > > >> > > > > > >> > Hi Thomas, > > > > > >> > > > > > > >> > importing proxy stuff would be the first great stuff. > > > > > >> > > > > > > >> > i'd like to see some pagination API (like PageRequest etc in > > > spring > > > > > >> world) > > > > > >> > which are more user friendly that @FirstResult and > @MaxResult). > > > > > >> > > > > > > >> > wdyt? > > > > > >> > > > > > > >> > *Romain Manni-Bucau* > > > > > >> > *Twitter: @rmannibucau <https://twitter.com/rmannibucau>* > > > > > >> > *Blog: **http://rmannibucau.wordpress.com/*< > > > > > >> > http://rmannibucau.wordpress.com/> > > > > > >> > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > > > > > >> > *Github: https://github.com/rmannibucau* > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > 2013/2/20 Thomas Hug <[email protected]> > > > > > >> > > > > > > >> > > CDI Query has now a completely Solder-free POM. Feel free to > > > drop > > > > > >> > comments > > > > > >> > > on the API - some parts might actually be fully excluded > (e.g. > > > > home > > > > > >> and > > > > > >> > > critera APIs). > > > > > >> > > > > > > > >> > > On Tue, Feb 12, 2013 at 10:00 PM, Mark Struberg < > > > > [email protected]> > > > > > >> > wrote: > > > > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > Thanks Thomas, great news! > > > > > >> > > > > > > > > >> > > > LieGrue, > > > > > >> > > > strub > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > >________________________________ > > > > > >> > > > > From: Thomas Hug <[email protected]> > > > > > >> > > > >To: "[email protected]" < > > > > > >> > > > [email protected]> > > > > > >> > > > >Sent: Tuesday, February 12, 2013 4:10 PM > > > > > >> > > > >Subject: Re: cdi-query, no news? > > > > > >> > > > > > > > > > >> > > > >FYI, I've started to "de-solderize" CDI Query and move > > things > > > > to > > > > > >> > depend > > > > > >> > > on > > > > > >> > > > >DS Core [1]: > > > > > >> > > > >https://github.com/ctpconsulting/query/tree/deltaspike > > > > > >> > > > > > > > > > >> > > > >Todos: > > > > > >> > > > >[x] Replace ServiceHandler > > > > > >> > > > >[_] Include Property utils > > > > > >> > > > >[_] Replace JBoss Logging > > > > > >> > > > > > > > > > >> > > > >Any feedback welcome. > > > > > >> > > > > > > > > > >> > > > >[1] including this modification > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/DELTASPIKE-113?focusedCommentId=13576531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13576531 > > > > > >> > > > > > > > > > >> > > > >On Mon, Feb 11, 2013 at 6:01 PM, Romain Manni-Bucau > > > > > >> > > > ><[email protected]>wrote: > > > > > >> > > > > > > > > > >> > > > >> a review of the API i guess > > > > > >> > > > >> > > > > > >> > > > >> what is missing today is probably the pagination > helpers > > > > > >> > (PageRequest > > > > > >> > > > for > > > > > >> > > > >> instance) > > > > > >> > > > >> > > > > > >> > > > >> but technically all is fine IMO > > > > > >> > > > >> > > > > > >> > > > >> *Romain Manni-Bucau* > > > > > >> > > > >> *Twitter: @rmannibucau < > https://twitter.com/rmannibucau > > >* > > > > > >> > > > >> *Blog: **http://rmannibucau.wordpress.com/*< > > > > > >> > > > >> http://rmannibucau.wordpress.com/> > > > > > >> > > > >> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > > > > > >> > > > >> *Github: https://github.com/rmannibucau* > > > > > >> > > > >> > > > > > >> > > > >> > > > > > >> > > > >> > > > > > >> > > > >> 2013/2/11 Jason Porter <[email protected]> > > > > > >> > > > >> > > > > > >> > > > >> > I know I'm playing the necromancer, but please > forgive > > > me. > > > > We > > > > > >> have > > > > > >> > > > >> > InvocationHandler, which looks like it would work as > a > > > > > >> > > ServiceHandler > > > > > >> > > > >> > substitute. What else is needed to get CDI Query into > > > > > >> DeltaSpike? > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > On Sun, Nov 18, 2012 at 12:35 PM, Romain Manni-Bucau > > > > > >> > > > >> > <[email protected]>wrote: > > > > > >> > > > >> > > > > > > >> > > > >> > > +1, it is a must have for cdi world > > > > > >> > > > >> > > Le 18 nov. 2012 20:04, "john.d.ament" < > > > > > >> [email protected]> > > > > > >> > a > > > > > >> > > > >> écrit : > > > > > >> > > > >> > > > > > > > >> > > > >> > > > RE ServiceHandler - I was one of those who > > previously > > > > > >> > suggested > > > > > >> > > > >> > bringing > > > > > >> > > > >> > > it > > > > > >> > > > >> > > > over to DeltaSpike, you can see DELTASPIKE-113 > and > > > find > > > > > the > > > > > >> > > thread > > > > > >> > > > >> > about > > > > > >> > > > >> > > it > > > > > >> > > > >> > > > from April of this year. At the time, I was in a > > > > > position > > > > > >> > > where I > > > > > >> > > > >> > > couldn't > > > > > >> > > > >> > > > spend much time on open source contribution. > I've > > > > > recently > > > > > >> > > > changed > > > > > >> > > > >> > jobs, > > > > > >> > > > >> > > > to > > > > > >> > > > >> > > > something that's going to help me spend some more > > > time > > > > > with > > > > > >> > the > > > > > >> > > > open > > > > > >> > > > >> > > source > > > > > >> > > > >> > > > community, and believe I can pick it back up if > > we're > > > > > >> ready. > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > If everyone's ok with it I can start a new thread > > for > > > > 113 > > > > > >> or > > > > > >> > > > revive > > > > > >> > > > >> the > > > > > >> > > > >> > > old > > > > > >> > > > >> > > > thread (though it may come through with a large > > pile > > > of > > > > > >> dust). > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > Regards, > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > John > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > -- > > > > > >> > > > >> > > > View this message in context: > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > http://apache-deltaspike-incubator-discussions.2316169.n4.nabble.com/cdi-query-no-news-tp4654029p4654036.html > > > > > >> > > > >> > > > Sent from the Apache DeltaSpike Incubator > > Discussions > > > > > >> mailing > > > > > >> > > list > > > > > >> > > > >> > > archive > > > > > >> > > > >> > > > at Nabble.com. > > > > > >> > > > >> > > > > > > > > >> > > > >> > > > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > -- > > > > > >> > > > >> > Jason Porter > > > > > >> > > > >> > http://en.gravatar.com/lightguardjp > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > >
