yes - we are using @Typed() (empty) >only< for internal util- and helper-classes which shouldn't be beans - but if we don't veto such classes, it doesn't make sense to mark such classes with @Typed(). (as you said - they are still injectable beans (at least with @New).)
as an alternative we can disable the possibility to deactivate @Exclude for internal classes, however, this ticket is open (and "in progress") since april - please start such discussions a bit earlier (if possible). regards, gerhard 2012/6/9 Mark Struberg <[email protected]> > @New in combination with @Typed is perfectly fine! > > @Typed is perfectly fine on it's own. Using @Exclude() is only fine as > long as you don't disable it. As this scenario is possible, we shall only > use @Typed() and not use @Exclude() in DS internally. > > LieGrue, > strub > > > > ----- Original Message ----- > > From: Gerhard Petracek <[email protected]> > > To: [email protected] > > Cc: > > Sent: Saturday, June 9, 2012 12:05 PM > > Subject: Re: [jira] [Resolved] (DELTASPIKE-161) veto internal beans > annotated with @Typed() > > > > hi, > > > > right now we only use @Typed() for util, helper,... classes. > > we can change it at any time if we really have a case which isn't just > > theory (imo we shouldn't use @Typed() in combination with @New at all). > > > > regards, > > gerhard > > > > > > > > 2012/6/9 Mark Struberg <[email protected]> > > > >> I don't get that issue. > >> > >> Yes, we should not use @Exclude() instead of @Typed internally. > >> > >> But no, we MUST NOT veto() beans which are @Typed()! > >> > >> @Typed() beans can still be used for @New! > >> > >> LieGrue, > >> strub > >> > >> > >> > >> ----- Original Message ----- > >> > From: Gerhard Petracek (JIRA) <[email protected]> > >> > To: [email protected] > >> > Cc: > >> > Sent: Thursday, June 7, 2012 2:12 PM > >> > Subject: [jira] [Resolved] (DELTASPIKE-161) veto internal beans > >> annotated with @Typed() > >> > > >> > > >> > [ > >> > > >> > > > https://issues.apache.org/jira/browse/DELTASPIKE-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > >> > ] > >> > > >> > Gerhard Petracek resolved DELTASPIKE-161. > >> > ----------------------------------------- > >> > > >> > Resolution: Fixed > >> > > >> >> veto internal beans annotated with @Typed() > >> >> ------------------------------------------- > >> >> > >> >> Key: DELTASPIKE-161 > >> >> URL: > >> https://issues.apache.org/jira/browse/DELTASPIKE-161 > >> >> Project: DeltaSpike > >> >> Issue Type: Improvement > >> >> Components: Core > >> >> Affects Versions: 0.2-incubating > >> >> Reporter: Gerhard Petracek > >> >> Assignee: Gerhard Petracek > >> >> Fix For: 0.3-incubating > >> >> > >> >> > >> >> we shouldn't use @Exclude internally because it's > > possible to > >> > deactivate it. > >> > > >> > -- > >> > This message is automatically generated by JIRA. > >> > If you think it was sent incorrectly, please contact your JIRA > >> administrators: > >> > > > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > >> > For more information on JIRA, see: > >> http://www.atlassian.com/software/jira > >> > > >> > > >
