Hi Rob

I've just looked at your patch here:
https://savannah.gnu.org/patch/index.php?8947

This seems a bit odd to me:

+    # Don't try to execute a data file, which is used by some tests
+    # to compare output.
+    if {[regexp "^\.txt$" $prog]} {
+      return ""
+    }

Wouldn't it be better to not call unix_load with such an argument?

Also, the patch contains a proc definition called make_absolute.  It's
redundant -- Tcl offers `file normalize'.

Cheers,
Ben

Attachment: signature.asc
Description: Digital signature

_______________________________________________
DejaGnu mailing list
DejaGnu@gnu.org
https://lists.gnu.org/mailman/listinfo/dejagnu

Reply via email to