Timo Aaltonen pushed to branch upstream-unstable at X Strike Force / driver /
xserver-xorg-video-intel
Commits:
e95490a7 by Ville Syrjälä at 2019-09-19T18:40:07+03:00
sna: Use -Wno-clobbered
../src/sna/sna_composite.c:567:11: warning: variable ‘sx’ might be clobbered by
‘longjmp’ or ‘vfork’ [-Wclobbered]
int16_t sx = src_x + tx - (dst->pDrawable->x + dst_x);
^~
etc.
I had a quick look at a few of the cases and they seemed fine to me,
so feels like gcc just being dense.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
2fae3b89 by Ville Syrjälä at 2019-09-19T18:41:21+03:00
sna: Shut up more compiler warns
Suppress more compiler warnings.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
04d8411d by Ville Syrjälä at 2019-09-19T18:41:21+03:00
sna: undef FontSetPrivate() before redefining it
Avoid the compiler gettings upset about us redefining
FontSetPrivate().
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
f9f318e4 by Ville Syrjälä at 2019-09-19T18:41:21+03:00
sna: Replace fall through comments with standard form
gcc doesn't like extra stuff in the fall through comments.
Replace them with the standard form.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
8cad9980 by Ville Syrjälä at 2019-09-19T18:41:21+03:00
sna: Annotate more fall throughs
Sprinkle fall through comments where needed.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
1804eacc by Ville Syrjälä at 2019-09-19T18:41:21+03:00
sna: Add sna_br13_color_depth()
Refactor the BR13 color depth setup to common helper. This
eliminates a bunch of implicit fall through warns.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
b88d9287 by Ville Syrjälä at 2019-09-19T19:01:16+03:00
sna/fb: Eliminate implicit fallthrough
Duplicate a bit of code in FbDoLeftMaskByteRRop() switch statement
to avoid the fall through.
And while at it sort the cases based on the left byte and length.
Makes the pattern matcher in my brain much happier.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
4b26ec2e by Ville Syrjälä at 2019-09-19T19:01:16+03:00
uxa: Use named initializers
Silence the compiler warning about missing initializers
by using named initializers.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
696f7eda by Ville Syrjälä at 2019-09-19T19:01:16+03:00
Avoid missing initializer warning
Use an empty {} as the terminator in intel_device_match[] to avoid
the warning about missing initlizers.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
24a06fef by Ville Syrjälä at 2019-09-19T19:01:16+03:00
sna: Use named initializers
Avoid -Wno-missing-field-initializers by using named
initializers.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
17ecd906 by Ville Syrjälä at 2019-09-19T19:01:19+03:00
sna: Increase the size of the path name buffer a bit
../src/intel_device.c: In function ‘__intel_open_device__pci.isra.6’:
../src/intel_device.c:321:25: warning: ‘%s’ directive writing up to 255 bytes
into a region of size 247 [-Wformat-overflow=]
sprintf(path + base, "%s", de->d_name);
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
97ce0215 by Ville Syrjälä at 2019-09-19T19:17:03+03:00
sna: Use memcmp() to avoid strict aliasing warns
../src/sna/sna_display.c: In function ‘sna_covering_crtc’:
../src/sna/sna_display.c:8235:34: warning: dereferencing type-punned pointer
will break strict-aliasing rules [-Wstrict-aliasing]
if (*(const uint64_t *)box == *(uint64_t *)&crtc->bounds) {
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
d8a3db25 by Ville Syrjälä at 2019-09-19T19:17:24+03:00
sna: Avoid strict aliasing violations with glyphinfo
Just access the xGlyphInfo members directly to avoid the
compiler getting upset about strict aliasing violations.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
e4a8d533 by Ville Syrjälä at 2019-09-19T19:18:40+03:00
sna/fb: Use memcpy() to avoid strict aliasing violations
Replace the cast+deref with memcpy() so that we don't upset
the compiler's strict aliasing rules.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
be30b162 by Ville Syrjälä at 2019-09-19T19:20:20+03:00
xvmc: Eliminate strict aliasing violations
Just access both halves of the motion vector thing
directly instead of doung the cast to uint and deref.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
070fb84e by Ville Syrjälä at 2019-09-19T19:22:18+03:00
sna/fb: Initialize xoff/yoff
The compiler seems to think src/mask xoff/yoff can be used
uninitialized. Zero them to make sure.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
fbe15cf4 by Ville Syrjälä at 2019-09-19T19:22:18+03:00
sna: Use -Wno-maybe-uninitialized
The compiler seems incapable of deducing whether something
is used uninitialized or not.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
e95e9d41 by Ville Syrjälä at 2019-09-19T19:22:18+03:00
sna: Get rid of -Wno-shift-negative-value
Use a cast to avoid the "left shift of negative value
[-Wshift-negative-value]" warning, and get rid of the
suppression.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
97058e38 by Ville Syrjälä at 2019-09-19T19:22:18+03:00
uxa: Get rid of -Wno-shift-negative-value
The minimum CS URB entry size is 1. Let's use that
instead of 0 so that we don't end up left shifting
a -1.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
bfeeae4d by Ville Syrjälä at 2019-09-19T19:24:38+03:00
tools: Get rid of -Wno-sign-compare
Fix the sign comparison warnings by changing some types, and
using a few casts.
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
581ddc5d by Ville Syrjälä at 2019-09-19T19:24:42+03:00
sna: Fix compiler warnings due to DrawablePtr vs. PixmapPtr
Deal with xserver commit 8e3b26ceaa86 ("Make PixmapDirtyUpdateRec::src
a DrawablePtr")
Not sure this is still correct though. Is this stuff limited to
pixmaps anymore?
Signed-off-by: Ville Syrjälä <[email protected]>
- - - - -
c6cb1b19 by Chris Wilson at 2019-09-27T20:37:33+01:00
sna: Squelch compiler warning for unused var
sna_display.c: In function ‘crtc_init_gamma’:
sna_display.c:7462:28: warning: unused variable ‘lut’ [-Wunused-variable]
sna_display.c:7444:14: warning: unused variable ‘sna’ [-Wunused-variable]
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
bff5eca4 by Chris Wilson at 2019-10-07T14:16:28+01:00
sna: Scale cpp by 8 for bit depth
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111916
Fixes: 1804eacc85da ("sna: Add sna_br13_color_depth()")
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
b5ac286c by Chris Wilson at 2019-11-02T21:10:39+00:00
sna: Close each client op with an arbitrartion check
Minimise preemption latency by frequently checking for pending preemption
events in between X11 client requests.
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
cb6bff95 by Peter Wu at 2019-11-15T19:20:30+00:00
sn: fix PRIME output support since xserver 1.20
Since "Make PixmapDirtyUpdateRec::src a DrawablePtr" in xserver, the
"src" pointer might point to the root window (created by the server)
instead of a pixmap (as created by xf86-video-intel). Use
get_drawable_pixmap to handle both cases.
When built with -fsanitize=address, the following test on a hybrid
graphics laptop will trigger a heap-buffer-overflow error due to
to_sna_from_pixmap receiving a window instead of a pixmap:
xrandr --setprovideroutputsource modesetting Intel
xrandr --output DP-1-1 --mode 2560x1440 # should not crash
glxgears # should display gears on both screens
With nouveau instead of modesetting, it does not crash but the external
monitor remains blank aside from a mouse cursor. This patch fixes both.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100086
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111976
Signed-off-by: Peter Wu <[email protected]>
Reviewed-by: Ville Syrjälä <[email protected]>
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
e628d226 by Chris Wilson at 2019-11-17T15:12:15+00:00
sna: Fix overflow calculation for number of boxes that fit
We detect when the number of boxes we wished to emit into the batch
would overflow, but then miscalculated the number that would actually fit..
References: https://bugs.freedesktop.org/show_bug.cgi?id=112296
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
0867eea6 by Chris Wilson at 2019-11-27T12:09:28+00:00
Update buglink for gitlan issues
Issue tracking has been moved from a bugzilla instance to a gitlab
instance to go alongside and integrated with the gitlab repo, still all on
freedesktop.org.
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
d90a2ff1 by Chris Wilson at 2019-12-09T14:41:14+00:00
Revert "sna: Close each client op with an arbitrartion check"
This reverts commit b5ac286c9bb0 as it escaped before being completed.
It proved it's worth in preventing sna from hogging the GPU for too long
under x11perf stress, but it didn't check to see if there was enough
space left in the batch before emitting the dword. Simply revert the
patch for now.
Reported-by: Matti Hämäläinen <[email protected]>
Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/issues/174
Signed-off-by: Chris Wilson <[email protected]>
- - - - -
f66d3954 by Ville Syrjälä at 2019-12-09T22:26:46+00:00
sna: Fix dirtyfb detection
Fix the accidentally swapped bpp and depth values passed to
the addfb ioctl when we're testing for dirtyfb presence.
Currently the addfb fails every time so we don't even test
the actual dirtyfb ioctl.
Signed-off-by: Ville Syrjälä <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
- - - - -
30 changed files:
- configure.ac
- src/intel_device.c
- src/intel_module.c
- src/legacy/i810/xvmc/I810XvMC.c
- src/meson.build
- src/sna/blt.c
- src/sna/fb/fb.h
- src/sna/fb/fbpict.c
- src/sna/fb/fbspan.c
- src/sna/gen2_render.c
- src/sna/gen3_render.c
- src/sna/gen4_render.c
- src/sna/gen5_render.c
- src/sna/gen6_render.c
- src/sna/gen7_render.c
- src/sna/gen8_render.c
- src/sna/gen9_render.c
- src/sna/kgem.c
- src/sna/meson.build
- src/sna/sna.h
- src/sna/sna_accel.c
- src/sna/sna_blt.c
- src/sna/sna_composite.c
- src/sna/sna_damage.h
- src/sna/sna_display.c
- src/sna/sna_display_fake.c
- src/sna/sna_dri2.c
- src/sna/sna_driver.c
- src/sna/sna_glyphs.c
- src/sna/sna_io.c
The diff was not included because it is too large.
View it on GitLab:
https://salsa.debian.org/xorg-team/driver/xserver-xorg-video-intel/-/compare/6f4972d5c368c30e971a23c1dc370d3e43761282...f66d39544bb8339130c96d282a80f87ca1606caf
--
View it on GitLab:
https://salsa.debian.org/xorg-team/driver/xserver-xorg-video-intel/-/compare/6f4972d5c368c30e971a23c1dc370d3e43761282...f66d39544bb8339130c96d282a80f87ca1606caf
You're receiving this email because of your account on salsa.debian.org.
