Sebastien Delafond <[EMAIL PROTECTED]> wrote: > On Tue, May 13, 2008 at 09:37:33AM -0400, Peter S Galbraith wrote: > > Sorry to have been too busy to add org-mode to emacs-goodies-el. But > > I'm sure that your package will be very popular. > > > > Looking at it now, I see that it is a large collection of files, and as > > such it is probably better packaged as it's own package anyway. > > no worries at all, I also figured since it was quite big it could be > its own package.
Cool. > > I have looked at http://ftp-master.debian.org/new/org-mode_6.02b-1.html > > and I do have one question: Why have you put the contrib elisp files > > under: > > > > /usr/share/org-mode/lisp/ > > > > Doesn't that break Debian-emacs policy? > > ah, that's cool, I was looking forward to having an expert emacs > packager review my first attempt :) > > So, do you think the contrib files should live (and be compiled) at > the same place the regular .el files are ? I wasn't sure, and since > they're not officially part of org-mode, I figured I'd put them in > /usr/share/org-mode/contrib (somehow my rules file must mess up and > put them under /usr/share/org-mode/lisp instead). There are two separate here (and I haven't looked at your build process, only at the web page above). The first is that you shouldn't put /usr/share/emacs/site-lisp/org-mode/ in the load-path anyway. You should link the files into emacs-specific directories such as /usr/share/emacs21/site-lisp/org-mode/ and byte-compile them there. The second is that I would put the contrib files under /usr/share/emacs/site-lisp/org-mode/contrib/ or even simply: /usr/share/emacs/site-lisp/org-mode/ although I'll admit that having the contrib directory makes it clear that these are contributed files. > Also, does the way I handle the 2 xemacs-specific files make sense ? I > didn't put the whole distribution under /usr/share/xemacs/org-mode > again, just the 2 xemacs-specific files, but I'm not sure if doing > this is OK. Following from the above, you don't need to put anything under a directory like /usr/share/xemacs/org-mode either. They can be under /usr/share/emacs/site-lisp/org-mode/ (since that directory won't be in the load-path) and linked into /usr/share/xemacs21/site-lisp/org-mode/ in the emacs-install script. The emacs-goodies-el package has files that are not installed for various flavours of emacs, and a mechanism in the emacs-install script to handle that. > Anyway, thanks a lot for your comments so far ! Cheers, > > --Seb I haven't looked at the 50org-mode.el startup file, so perhaps you already do this... It should skip package setup if the package is removed but not purged. Also, if package initialisation is complicated, do that bulk of it in another file outside of the /etc directory tree, and simply load that file from a streamlined 50org-mode.el file. Hope this helps. -- Peter S. Galbraith, Debian Developer <[EMAIL PROTECTED]> http://people.debian.org/~psg GPG key 1024/D2A913A1 - 97CE 866F F579 96EE 6E68 8170 35FF 799E -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
