> * the debian/.gitignore is not really needed because those files are cleaned > up automatically and should thus never remain
I need to this because of gbp. It really is not important. :/ > * the Maintainer is set to celenity, the upstream of phoenix-esr. This is > not > what the Maintainer field should contain. It needs to have your name in > it. Ok. > * the Uploaders field has your name and the one of celenity but neither of > you are uploading the package. The Uploaders field is necessary in cases > where the Maintainer field contains a mailinglist address which is not the > case here > * Rules-Requires-Root: no is no longer needed as it is the default now Ok. > * you declare a Conflicts: with "phoenix" -- what package is that? Phoenix-esr is for the firefox-esr (debian stable and testing) Phoenix is for firefox (just unstable) I'll upload it after uploading phoenix-esr be done We use these for OBS: https://codeberg.org/celenity/Phoenix-Debian/src/branch/master > * should your Depends on firefox-esr be versioned or will phoenix-esr also > work with very old versions of firefox-esr? It works with older versions. > * you added debian/upstream/signing-key.asc which is great but uscan does > not > find https://codeberg.org/celenity/Phoenix/archive/2025.08.06.1.tar.gz.asc > Did upstream forget to sign that release or is your pgpsigurlmangle wrong? Ok, I'll remove the gpg key. Celenity does not sign tags. > * Your Files-Excluded in debian/copyright includes .git which is not part of > the upstream tarball Ok. > * why is the "unused" directory not part of Files-Excluded? I do not see the > windows or macos files being used in the package build and the file > unused/linux/phoenix-extended.js is created during the build > * please amend the clean target in debian/rules such that it removes the > files > created during the build like the archives and linux directories Ok. Unused fir is neededddddddddddd. Forget the upstream name. > Looking at the package firefox-esr-mobile-config which is very similar to > phoenix-esr (good that you declared a Conflicts with that package) I found > this: > > > https://salsa.debian.org/DebianOnMobile-team/firefox-esr-mobile-config/-/commit/a1c4b752fb62d87b13a5abc330dac7cea5464f82 > > Is phoenix-esr also affected by this problem and should the Debian package > thus > also add a postinst script doing something similar? It is not needed. Those are not related. Just because of this I add the mobile-config as a confilict: https://salsa.debian.org/amin_modaresi/phoenix-esr/-/jobs/7892214#L73 And firefox/firefox-esr doesn't accept an another name for policy.json > I'm on a trip with my family these days, hence I wasn't able to finish my > review but I wanted to send this unfinished review nevertheless so that you > can > already start replying to these points. I hope that you have a good trip Thank's for your time I fixed all of them
