Stuart, I appreciate you taking the time to comment on this.
On Thursday, October 10, 2024 11:20:44 PM MST Stuart Prescott wrote: > Hi Soren > > On 11/10/2024 06:26, Soren Stoutner wrote: > > This package is a dependency of the current version of python-libusb1. > > > > I indend to maintian it under the Debian Python team umbrella. > > pyinstaller is a very unusual dependency to have either for a package in > Debian. > > It's designed to build redistributable packages and can do so for > various operating systems; that's not a feature that is needed as a > build-depends for Debian packaging because we already have a > redistributable format - the .deb - and we already have the tooling to > make that. pyinstaller is also not something that would be needed at > runtime. I agree. It is a very unusual build-dependency. And python-libusb1 isn’t even using it for it’s main function. Rather, it is only used as part of the test suite here: https://salsa.debian.org/soren/python-libusb1/-/blob/master/usb1/ __pyinstaller/test_libusb1_packaging.py?ref_type=heads#L14 I believe this test was ignored previously, but recent changes in setuptools now causes it to fail. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1080134 I have offered to become a co-maintainer of python-libusb1 and Arnaud Fontaine graciously accepted. My interest is because I have recently become the maintainer of python-trezor, which will be removed from testing if this bug isn’t fixed. Arnaud told me he doesn’t have much time to to work on packaging right now. I asked him what he thought was the best way to fix this bug: somehow disable this test (a few basic attempts to do so didn’t work and I don’t know enough Python to know why) or package python-pyinstaller. When he didn’t respond I decided to proceed with the second option. > I had a look at python-libusb1 [1] because I was curious how it might > use pyinstaller. The only use I can see is in making it possible for > other projects to use python-libusb1 more easily in their own > pyinstaller projects by advertising a plugin entry-point [2][3]. That's > not something that we need to worry about in Debian, and it's also > neither a runtime nor buildtime dependency. > > [1] https://github.com/vpelletier/python-libusb1 > [2] https://pyinstaller.org/en/stable/hooks.html > [3] https://setuptools.pypa.io/en/latest/userguide/entry_point.html > > I think you can save yourself from packaging pyinstaller for Debian; > given that pyinstaller includes all manner of things you'd need to build > for other operating systems, that's probably a good thing to avoid. It's > likely to be horrible to package. It is quite a difficult package compared to the only other Python package I have packaged from scratch. I currently have it building if I ignore a bunch of tests. And there are a few other difficulties that need to be ironed out. But upstream seems helpful, and I have already done enough of the work that I think I will proceed to just finish it. https://github.com/pyinstaller/pyinstaller/issues/8824 -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.
