On Tue, Feb 23, 2021 at 02:48:47PM +0100, Romain Porte wrote:
> Hi,
> 
> 2021-02-22 18:45 CET, Antonio Terceiro:
> > Hi,
> >
> > On Mon, Feb 22, 2021 at 12:03:08PM +0100, Romain Porte wrote:
> > > This library is used to access run commercial BrowserStack service
> > > locally. It is able to download and execute the BrowserStack binaries
> > > automatically. (Include the long description here.)
> > >
> > > This package is introduced as a dependency for the gftools package. It
> > > is planned to be maintained with the help of the Debian Python team.
> >
> > Note that downloading and running binaries from arbitrary locations is
> > is not suitable to Debian main.
> 
> Here is a copy from the source code that may download and run
> (proprietary it seems) binaries from arbitrary locations:
> 
>     class LocalBinary:
>       def __init__(self):
>         is_64bits = sys.maxsize > 2**32
>         self.is_windows = False
>         osname = platform.system()
>         if osname == 'Darwin':
>           self.http_path = 
> "https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-darwin-x64";
>         elif osname == 'Linux':
>           if is_64bits:
>             self.http_path = 
> "https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-x64";
>           else:
>             self.http_path = 
> "https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-ia32";
>         else:
>           self.is_windows = True
>           self.http_path = 
> "https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal.exe";
> 
> I agree this is not very good canditate for inclusion in main. The
> download is not done during package build time, but upon library
> invocation by the users.
> 
> Maybe this has place in non-free, or maybe it does not deserve to be
> packaged at all for Debian. Well, the work is done locally, so I am not
> sure which option is better.

If you end goal is to have gftools, you might want to patch the use of
browserstack-local out of it, if that's possible.

Attachment: signature.asc
Description: PGP signature

Reply via email to