> On 2019-09-05 18:38:09, Nicolas Schier wrote: > > Dear Antoine, > > > >> > Antoine, could you create a repository in salsa's 'debian' > >> > namespace? > >> > (My salsa account is 'nsc-guest'). > >> > >> Done: https://salsa.debian.org/debian/git-revise > > > > thanks for your fast reaction! > > Right now, I do not have any permissions than to create merge requests > > for debian/git-revise. > > Really? You seem to have created one here: > > https://salsa.debian.org/debian/git-revise/merge_requests/1 > > I merged it after review. > > > I'd like to have the CI stuff enabled (with 'debian/gitlab.yml' > > instead of '.gitlab.yml'), that the usual test suites can also run on > > the new official repo. Can you please enable that (or give me the > > permissions for doing that)? > > I added you as a developer.
Thanks! > >> > Would you be available as a sponsor (as soon as I have got rid of all > >> > lintian issues)? > >> > >> Sure! > > > > great! I uploaded the package to mentors: > > > > https://mentors.debian.net/package/git-revise > > > > (same state as in the Pull-Request). > > > > Could you have a look at it? > > (I am not sure, if I did the doc-base stuff correctly...) > > Could you hook up the test suite in autopkgtest somehow? > > The docbase stuff is usually in HTML, and to make it work you'd need to > build it with the Sphinx package, I think. It would be better to split > that out in a separate -doc package. > > Why did you mark the FHS patch as not needing forward? It would seem > like a useful contribution for upstream... > > All this can be done in a future incantation though. > > The stuff on mentors still has an empty postrm script, so it looks like > it's not exactly the same state as the merge request... > > python-git-revise-doc.docs refers to two non-existent files, so that > should definitely be fixed. It would be strange to have README.source > shipped, btw. And README.Debian doesn't need to be in the -doc package. > > For the (build-)depends, you might want to split lines on commas to make > future diffs smaller. You can also build-dep on debhelper-compat to pin > an exact version, which also removes the need for the extra > debian/compat file. > > Did you audit or review the upstream source? Thanks a lot for your detailed and criticial review. It seems I have been a bit too sloppily ... give me some days to handle your points. Kind regards, Nicolas -- epost: nico...@fjasle.eu irc://oftc.net/nsc ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f -- frykten for herren er opphav til kunnskap --
signature.asc
Description: PGP signature
