Hello, On 2018-08-02 05:28 AM, Jongmin Kim wrote: > Hello, Go team. > > I prepared packaging for https://github.com/tcnksm/go-gitconfig . > It is present at: > > https://salsa.debian.org/go-team/packages/golang-github-tcnksm-go-gitconfig .
Thank you for your work.
I have some comments:
d/rules:
- Why do you skip tests? Please add a comment when you do something
like this. This is especially intriguing because the tests pass on my
machine.
d/control:
- the short description is "use gitconfig values in Go"
Maybe "gitconfig values in Go". The "use" looks a big odd here.
- I am not sure I would link to the upstream-hosted documentation here
because it could fall out of sync with Debian.
Cheers,
--
Alexandre Viau
av...@debian.org
signature.asc
Description: OpenPGP digital signature
