Re: utelnetd

[peter]

    From: <to...@tuxteam.de>
    Date: Sun, 10 Nov 2024 17:30:42 +0100
> But perhaps Make is right and utelnetd is built and ready to go?
> 
> What evidence would you have that it is not so?

# ls -ld /usr/local/bin/u*
ls: cannot access '/usr/local/bin/u*': No such file or directory

# cd /usr
# find . -type f -name "utelnetd"
#

> Perhaps you need a "make clean" before, to force Make to actually
> do its thing? Missing that target, you might want to remove utelned,
> and perhaps utelnetd.o.

# make clean
PROGS: utelnetd
rm -f utelnetd *.o core

Now make gives a flock of complaints.  See below.  Eg. grantpt vs. 
getpt.  

The problem is Debian differing from the system where where the 
developer worked?  I need to change some names?

Thanks,                 ... P.

# make DEBUG=1 -f ./Makefile
PROGS: utelnetd
gcc -I. -pipe -DSHELLPATH=\"/bin/login\" -Wall -DDEBUG -g -Os   -c -o 
utelnetd.o utelnetd.c
utelnetd.c: In function ‘getpty’:
utelnetd.c:232:13: warning: implicit declaration of function ‘grantpt’; did 
you mean ‘getpt’? [-Wimplicit-function-declaration]
  232 |         if (grantpt(p)<0 || unlockpt(p)<0) {
      |             ^~~~~~~
      |             getpt
utelnetd.c:232:29: warning: implicit declaration of function ‘unlockpt’ 
[-Wimplicit-function-declaration]
  232 |         if (grantpt(p)<0 || unlockpt(p)<0) {
      |                             ^~~~~~~~
utelnetd.c:237:44: warning: implicit declaration of function ‘ptsname’; did 
you mean ‘ptsname_r’? [-Wimplicit-function-declaration]
  237 |         DEBUG_OUT("getpty(): got pty %s\n",ptsname(p));
      |                                            ^~~~~~~
utelnetd.c:112:40: note: in definition of macro ‘DEBUG_OUT’
  112 | #define DEBUG_OUT(...) fprintf(stderr, __VA_ARGS__)
      |                                        ^~~~~~~~~~~
utelnetd.c:237:19: warning: format ‘%s’ expects argument of type ‘char 
*’, but argument 3 has type ‘int’ [-Wformat=]
  237 |         DEBUG_OUT("getpty(): got pty %s\n",ptsname(p));
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~
      |                                            |
      |                                            int
utelnetd.c:112:40: note: in definition of macro ‘DEBUG_OUT’
  112 | #define DEBUG_OUT(...) fprintf(stderr, __VA_ARGS__)
      |                                        ^~~~~~~~~~~
utelnetd.c:237:39: note: format string is defined here
  237 |         DEBUG_OUT("getpty(): got pty %s\n",ptsname(p));
      |                                      ~^
      |                                       |
      |                                       char *
      |                                      %d
utelnetd.c:238:22: warning: cast to pointer from integer of different size 
[-Wint-to-pointer-cast]
  238 |         strcpy(line, (const char*)ptsname(p));
      |                      ^
utelnetd.c: In function ‘main’:
utelnetd.c:561:7: warning: pointer targets in passing argument 3 of 
‘accept’ differ in signedness [-Wpointer-sign]
  561 |       &salen)) < 0) {
      |       ^~~~~~
      |       |
      |       int *
In file included from utelnetd.c:45:
/usr/include/x86_64-linux-gnu/sys/socket.h:233:28: note: expected ‘socklen_t 
* restrict’ {aka ‘unsigned int * restrict’} but argument is of type 
‘int *’
  233 |      socklen_t *__restrict __addr_len);
      |      ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
utelnetd.c:597:32: warning: pointer targets in passing argument 1 of 
‘remove_iacs’ differ in signedness [-Wpointer-sign]
  597 |     ptr = remove_iacs(ts->buf1 + ts->wridx1, maxlen,
      |                       ~~~~~~~~~^~~~~~~~~~~~
      |                                |
      |                                char *
utelnetd.c:190:28: note: expected ‘unsigned char *’ but argument is of type 
‘char *’
  190 | remove_iacs(unsigned char *bf, int len, int *processed, int *num_totty) 
{
      |             ~~~~~~~~~~~~~~~^~
gcc  -I. -pipe -DSHELLPATH=\"/bin/login\" -Wall -DDEBUG -g -Os utelnetd.o  -o 
utelnetd
# --remove-section=.comment --remove-section=.note utelnetd
#
-- 
VoIP:   +1 604 670 0140
work: https://en.wikibooks.org/wiki/User:PeterEasthope