On Thu, 08 May 2014, Brian wrote: > On Thu 08 May 2014 at 12:10:02 -0300, Henrique de Moraes Holschuh wrote: > > On Mon, 05 May 2014, Andrei POPESCU wrote: > > > if grep -wqs text /proc/cmdline; then > > > log_warning_msg "Not starting Light Display Manager (lightdm); found > > > 'text' in kernel commandline." > > > [...] > > > fi > > > > This is broken. It will misfire on foo.text=<something>. > > It will. > > > This same issue has caused problems already, and IMHO it deserves a > > preemptive fix (even to stable).
... > 'text' was originally aimed solely at gdm. It has crept into lightdm but > not xdm or kdm. Could the 'preemptive fix' be to remove it? That would obviously work as well. That said, the anti-pattern exists and needs to be fixed. In wheezy, there are several broken scripts in /etc/init.d/* that have the broken "grep -w -s" test applied to the kernel command line. Some of those might have been fixed in unstable, but are in need of a stable update. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To UNSUBSCRIBE, email to debian-user-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140508200323.gh32...@khazad-dum.debian.net
