Torsten Hilbrich wrote:
>
> As announced, I looked into the source and made a first patch. Due
> its shortness I will append it to this posting. If anybody who is
> using the program too could test this patch, I could send it to the
> maintainer for possible inclusion.
Since a few days I'm working on about the same thing. Until now I got
the commandline accept ippp interfaces, got the load graph working, and
also the online detection works sort of, but is far from what I dream
of.
As this is my first experience in linux programming I will have to check
the manuals before I can create a patch. I think this will happen RSN.
Until then I will add some comments to your patch...
> --- wmppp.c.orig Sun Sep 27 22:32:53 1998
> +++ wmppp.c Sun Sep 27 22:33:02 1998
> @@ -310,10 +310,6 @@
> usage();
> exit(1);
> }
> - if (strncmp(argv[i+1], "ppp", 3)) {
Change this line to the following and leave it in the source:
if (strncmp(argv[i+1], "ppp", 3) && strncmp(argv[i+1], "ippp", 4)) {
> - usage();
> - exit(1);
> - }
> active_interface = argv[i+1];
> i++;
> break;
[rest of patch]
Without looking at the source again I guess the rest dealt with the
online detection. I rewrote the funtion stillonline to check
/dev/isdninfo if it's a ippp interface. Unfortunately this will not work
in all cases. See my posting "Wie prüfen ob ippp0 online ist?" and the
replies on de.alt.comm.isdn4linux.
I copied the function get_statistics without changes from wmifs to get
the graph drawing work.
Hope this helps 'til I have a real patch ready. BTW, used versions are
wmppp-1.3.0 and wmifs-1.3b from http://windowmaker.mezaway.org.
Thomas
P.S. Torsten, as you can guess from my adress private mail replies in
german are welcome.
