On 15/08/14 03:31 PM, Cédric Boutillier wrote:
On Fri, Aug 15, 2014 at 09:07:49PM +0200, Cédric Boutillier wrote:
Hi Caitlin,
I had today a look at ruby-hoe. The package looks great. I have two
comments:
- I think the upstream version should be 3.0.12+dfsg, since the upstream
archive is repacked to remove the Hoe.pdf file. This was the case for
some time, but then we overlooked it, it seems.
Done. Note that lintian now produces
debian-watch-file-should-dversionmangle-not-uversionmangle. This is an
ongoing issue [1] and should be ignored. the uversionmangle is necessary
to automatically add +dfsg to the tarball.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748465
- The documentation in /usr/share/doc/ruby-hoe/rdoc contains only the
History.rdoc and README.rdoc files. You need to add 'lib/' at the end
of the line in the rdoc command in the override_dh_installdocs target.
Done
Another remark:
the text of the license in debian/copyright matches the one for the
MIT/Expat license. You can rename it from MIT to Expat to avoid
confusion with other versions of the MIT license.
Done.
Thanks!
Caitlin
Cédric
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: https://lists.debian.org/[email protected]
