Control: tags -1 -patch Hi Pino!
On Fri, Mar 05, 2021 at 07:17:24PM +0100, Pino Toscano wrote: > Did you actually check that it fixes the problem for you? > The thing is, in C++ (at least since C++98) the delete operator is > defined to be a no-op for a null pointer, much like free() in C. > Hence, constructs like "if (foo) delete foo;" are essentially doing > null pointer checks twice, and with the same no-op result. > > A possible cause of the crash could be that the item being deleted was > already deleted, and thus there was a stale pointer somewhere. That is > my own speculation though. > > Because of this, I'm inclined to remove the "patch" tag from this bug; > I'd like to hear from Dmitry what he thinks about it (since he already > handled this bug). I agree with you, the patch is probably not going to work. Unfortunately, I did not have time to investigate this properly yet, but I answered some upstream's questions and I hope they will fix it. -- Dmitry Shachnev
signature.asc
Description: PGP signature
