On Thu, Feb 04, 2021 at 01:39:04PM -0500, John David Anglin wrote: > That's the dichotomy. I know hppa but not Qt. It painful to find the > parts of Qt that depend on endianness, stack layout, and possibly the NaN > representation.
I also don’t know the QML / V4 engine code well. But the qv4staticvalue_p.h file you mentioned has an excellent comment which describes how it treats different double values: https://sources.debian.org/src/qtdeclarative-opensource-src/5.15.2+dfsg-4/src/qml/common/qv4staticvalue_p.h/#L140 For NaN, you probably need to check if these masks are correct: https://sources.debian.org/src/qtdeclarative-opensource-src/5.15.2+dfsg-4/src/qml/common/qv4staticvalue_p.h/#L285 https://sources.debian.org/src/qtdeclarative-opensource-src/5.15.2+dfsg-4/src/qml/common/qv4staticvalue_p.h/#L305 and this method: https://sources.debian.org/src/qtdeclarative-opensource-src/5.15.2+dfsg-4/src/qml/common/qv4staticvalue_p.h/#L354 From endianness point of view, Qt Declarative should be mostly fine. I looked at s390x test logs and only few tests are failing: - qmltestrunner::item-grabber::test_endresult* — for this I filed https://bugreports.qt.io/browse/QTBUG-56806 - tst_qmldiskcache::regenerateAfterChange() — this one I didn’t notice before, and I will investigate it. It regressed somewhere between 5.11.3 and 5.12.2. -- Dmitry Shachnev
signature.asc
Description: PGP signature
