Hi Helmut! On Wed, Apr 22, 2020 at 08:39:16PM +0200, Helmut Grohne wrote: > The context of this bug is #798955 aka moving glibc headers from > /usr/include to /usr/include/<triplet>. When doing this, some packages > FTBFS with the symptom that <cstdlib> or <cmath> fail to find > #include_next <stdlib.h> or #include_next <math.h> respectively. The > cause is passing -isystem /usr/include/<triplet> to the compiler. I > asked libstdc++ upstream to fix this, but the reply was that passing > this flag is unsupported (see bug log of #798955). The takeaway is: > Pass -isystem /usr/include or -isystem /usr/include/<triplet> is broken. > > Unfortunately, qmake does exactly that. > [...] > > I can also propose a solution. When constructing INCPATH, any directory > that directly is a compiler search directory (not a subdirectory > thereof), the directory should be skipped. Doing so ensures that the > order of compiler search directories is not changed. The possible harm > seems quite limited given that the compiler will already search these > directories (just in the correct order). > > What do you think?
I think your patch makes sense. Can I ask you to forward it to upstream Gerrit [1] (see [2] for the instruction)? Unfortunately, upstream requires the patch author to sign a CLA so I cannot easily forward it under my account. Alternatively, you may publicly state that you license your patch under a permissive license (e.g. BSD), which should also work (but upstream does not like this much). In case you agree to forward it, please also fix the indentation, it should not contain tabs. [1]: https://codereview.qt-project.org/ [2]: https://wiki.qt.io/Gerrit_Introduction -- Dmitry Shachnev
signature.asc
Description: PGP signature
