On Mon, Mar 19, 2018 at 10:30:31PM +0100, Pino Toscano wrote: > In data lunedì 19 marzo 2018 15:10:43 CET, Helmut Grohne ha scritto: > > diff --minimal -Nru qtcreator-4.5.2/debian/rules > > qtcreator-4.5.2/debian/rules > > --- qtcreator-4.5.2/debian/rules 2018-03-17 17:26:40.000000000 +0100 > > +++ qtcreator-4.5.2/debian/rules 2018-03-19 14:37:33.000000000 +0100 > > @@ -5,15 +5,6 @@ > > > > DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH) > > > > -export CFLAGS := $(shell dpkg-buildflags --get CFLAGS) $(shell > > dpkg-buildflags --get CPPFLAGS) > > -export CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(shell > > dpkg-buildflags --get CPPFLAGS) > > -export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed > > Your patch drops the as-needed linking mode.
Yes, it does so intentionally. I checked the build logs (on amd64) and saw that the qmake debhelper build system passes -Wl,--as-needed anyway. Thus I concluded that explicit passing was unnecessary. Is there anything I could miss here? Regarding Lisandro's complaint regarding out-of-source builds: dh forwards the --builddirectory to dh_auto_configure. It's still out-of-source. Helmut
