Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
Dear release team,
The current version in stretch of kscd is affected by #850114.
This caused kscd to always retrieve the information for the same
test disc. This is fixed in the 4:16.08.1-2 version currently in sid and
since it's an rc bug I'm asking for an unblock.
I'm attaching the corresponding debdiff.
Happy hacking,
unblock kscd/4:16.08.1-2
-- System Information:
Debian Release: 9.0
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500,
'testing'), (500, 'stable'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf
Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
diff -Nru kscd-16.08.1/debian/changelog kscd-16.08.1/debian/changelog
--- kscd-16.08.1/debian/changelog 2016-10-18 23:59:43.000000000 +0200
+++ kscd-16.08.1/debian/changelog 2017-03-08 12:20:56.000000000 +0100
@@ -1,3 +1,12 @@
+kscd (4:16.08.1-2) unstable; urgency=medium
+
+ * Update patch: test_args_as_const.diff.
+ Thanks to Pere Nubiola Radigales for reporting and John Paul Adrian
+ Glaubitz for finding error
+ (Closes: 850114)
+
+ -- Maximiliano Curia <m...@debian.org> Wed, 08 Mar 2017 12:20:56 +0100
+
kscd (4:16.08.1-1) unstable; urgency=medium
[ Automatic packaging ]
diff -Nru kscd-16.08.1/debian/patches/test_args_as_const.diff
kscd-16.08.1/debian/patches/test_args_as_const.diff
--- kscd-16.08.1/debian/patches/test_args_as_const.diff 2016-10-18
23:59:43.000000000 +0200
+++ kscd-16.08.1/debian/patches/test_args_as_const.diff 2017-03-08
12:20:56.000000000 +0100
@@ -1,12 +1,21 @@
+From: Maximiliano Curia <m...@gnuservers.com.ar>
+Date: Wed, 8 Mar 2017 11:35:09 +0100
+Subject: test_args_as_const
+
commit 6dad65ec7a1523b78df821109238c21cc1e64b4b
Author: Maximiliano Curia <m...@gnuservers.com.ar>
Date: Wed Jun 1 20:13:28 2016 +0200
Pass some arguments as const
+---
+ mbmanager.cpp | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+diff --git a/mbmanager.cpp b/mbmanager.cpp
+index 2b17df4..d3e1775 100644
--- a/mbmanager.cpp
+++ b/mbmanager.cpp
-@@ -101,7 +101,7 @@
+@@ -101,7 +101,7 @@ static QString getArtist(MusicBrainz5::CRelease *release)
return getArtistFromArtistCredit(artistCredit);
}
@@ -15,7 +24,7 @@
{
QList<MBTrackInfo> tracks;
MBTrackInfo track;
-@@ -126,7 +126,7 @@
+@@ -126,7 +126,7 @@ static QList<MBTrackInfo> unknownTracks(QString
&discArtist, DiscId *m_discid)
return tracks;
}
@@ -24,7 +33,7 @@
{
QList<MBTrackInfo> tracks;
if (! medium) return tracks;
-@@ -156,7 +156,7 @@
+@@ -156,7 +156,7 @@ static QList<MBTrackInfo> getTracks(MusicBrainz5::CMedium
*medium, QString &disc
return tracks;
}
@@ -33,13 +42,3 @@
{
metadata = query.Query("discid", discId);
// Check to see how many items were returned from the server
-@@ -216,7 +216,8 @@
-
- int discid_ok = discid_read_sparse(m_discid, qPrintable(device), 0);
- if (discid_ok) {
-- std::string discId(discid_get_id(m_discid));
-+ //std::string discId(discid_get_id(m_discid));
-+ std::string discId("64e.YDM.N2tZJzmqrN48iWfJ9.4-");
- try
- {
- MusicBrainz5::CMetadata metadata, fullMetadata;
