Bug#688767: systemsettings: Crash in "Display and Monitor"

[David Smith]

tags 688767 patch
thanks

Hello! I can confirm that the patch that upstream made for KDE 4.10 applies to 
kgamma in KDE 4.8.4 and fixing the crash.
Please consider applying this patch to Wheezy.

Upstream patch is here:
https://projects.kde.org/projects/kde/kdegraphics/kgamma/repository/revisions/1918f145261a52a3b2a917c6784c2cebecbb4064/diff/kcmkgamma/kgamma.cpp

Or see attached.

Thanks for your time.

-David

commit 1918f145261a52a3b2a917c6784c2cebecbb4064
Author: Christoph Feck <christ...@maxiom.de>
Date:   Sun Nov 11 02:19:01 2012 +0100

    Fix crash when XVidExtWrap is not available
    
    This can happen when run as root
    BUG: 292335
    FIXED-IN: 4.10

diff --git a/kcmkgamma/kgamma.cpp b/kcmkgamma/kgamma.cpp
index ffe29ea..890ba99 100644
--- a/kcmkgamma/kgamma.cpp
+++ b/kcmkgamma/kgamma.cpp
@@ -70,7 +70,7 @@ KGamma::KGamma(QWidget* parent_P, const QVariantList &)
     :KCModule(KGammaConfigFactory::componentData(), parent_P), rootProcess(0)
 {
   bool ok;
-  GammaCorrection = true;
+  GammaCorrection = false;
   xv = new XVidExtWrap(&ok, NULL);
   if (ok) { /* KDE 4: Uneccessary test, when all KCM wrappers do conditional 
loading */
     xv->getGamma(XVidExtWrap::Red, &ok);
@@ -94,6 +94,7 @@ KGamma::KGamma(QWidget* parent_P, const QVariantList &)
       xv->setScreen(currentScreen);
 
       rootProcess = new KProcess;
+      GammaCorrection = true;
       setupUI();
       saved = false;
 
@@ -107,10 +108,9 @@ KGamma::KGamma(QWidget* parent_P, const QVariantList &)
       }
       load();
     }
-    else {  //something is wrong, show only error message
-      GammaCorrection = false;
-      setupUI();
-    }
+  }
+  if (!GammaCorrection) { //something is wrong, show only error message
+    setupUI();
   }
 }