Package: release.debian.org
Severity: normal
X-Debbugs-Cc: plasma-dia...@packages.debian.org, Debian Qt/KDE Maintainers 
<debian-qt-kde@lists.debian.org>
Control: affects -1 + src:plasma-dialer
User: release.debian....@packages.debian.org
Usertags: unblock

Dear Release Team,

please unblock package plasma-dialer.

[ Reason ]
It contains the following changes:
* New upstream release (6.3.5).
  - Fix: do not track same voicecall object multiple times.

[ Tests ]
Basic test of launching plasma-dialer locally. I don’t have the required
hardware to test further but the fix in this release is quite minimal.

[ Risks ]
Only backport of upstream commits that apply cleanly. Further fixes can
easily be backported or the changes reverted.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


Thanks!


unblock plasma-dialer/1:6.3.5-1
diff -Nru plasma-dialer-6.3.4/CMakeLists.txt plasma-dialer-6.3.5/CMakeLists.txt
--- plasma-dialer-6.3.4/CMakeLists.txt  2025-04-02 05:37:43.000000000 +0200
+++ plasma-dialer-6.3.5/CMakeLists.txt  2025-05-06 19:58:47.000000000 +0200
@@ -4,12 +4,12 @@
 
 cmake_minimum_required (VERSION 3.16)
 
-set(PROJECT_VERSION "6.3.4")
+set(PROJECT_VERSION "6.3.5")
 set(PROJECT_VERSION_MAJOR 6)
 
 project(plasma-dialer VERSION ${PROJECT_VERSION})
 
-set(PROJECT_DEP_VERSION "6.3.4")
+set(PROJECT_DEP_VERSION "6.3.5")
 set(QT_MIN_VERSION "6.7.0")
 set(KF6_MIN_VERSION "6.10.0")
 set(KDE_COMPILERSETTINGS_LEVEL "6.5.0")
diff -Nru plasma-dialer-6.3.4/debian/changelog 
plasma-dialer-6.3.5/debian/changelog
--- plasma-dialer-6.3.4/debian/changelog        2025-04-12 23:12:51.000000000 
+0200
+++ plasma-dialer-6.3.5/debian/changelog        2025-05-19 00:58:38.000000000 
+0200
@@ -1,3 +1,13 @@
+plasma-dialer (1:6.3.5-1) unstable; urgency=medium
+
+  * Team upload.
+
+  [ Aurélien COUDERC ]
+  * New upstream release (6.3.5).
+    - Fix: do not track same voicecall object multiple times.
+
+ -- Aurélien COUDERC <couc...@debian.org>  Mon, 19 May 2025 00:58:38 +0200
+
 plasma-dialer (1:6.3.4-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru plasma-dialer-6.3.4/debian/gbp.conf 
plasma-dialer-6.3.5/debian/gbp.conf
--- plasma-dialer-6.3.4/debian/gbp.conf 2025-04-07 22:29:42.000000000 +0200
+++ plasma-dialer-6.3.5/debian/gbp.conf 1970-01-01 01:00:00.000000000 +0100
@@ -1,5 +0,0 @@
-[DEFAULT]
-debian-branch = debian/latest
-upstream-branch = upstream/latest
-upstream-vcs-tag = v%(version)s
-pristine-tar = True
diff -Nru plasma-dialer-6.3.4/modem-daemon/src/mm-modem-controller.cpp 
plasma-dialer-6.3.5/modem-daemon/src/mm-modem-controller.cpp
--- plasma-dialer-6.3.4/modem-daemon/src/mm-modem-controller.cpp        
2025-04-02 05:37:43.000000000 +0200
+++ plasma-dialer-6.3.5/modem-daemon/src/mm-modem-controller.cpp        
2025-05-06 19:58:47.000000000 +0200
@@ -53,9 +53,10 @@
         During the following call to waitForFinished(), the DBus client waits 
for the DBus server to send a reply.
         In the meantime, the ModemManager instance will send the USSD request 
and wait for an USSD response.
         Once the ModemManager instance has received an USSD response, it will 
send a DBus response as well as a state update, in a possibly undefined order.
-        Even if the state update would be sent before the DBus response, it 
will be received from this code after the DBus response, as waitForFinished() 
waits for the correct DBus response and queues any other DBus activity (such as 
the state update).
-        Hence, the state update will always be received later than 
waitForFinished() returns.
-        Hence, the ussdInitiateComplete() call will contain the correct 
message, but the corresponding state update will only happen (milliseconds) 
later.
+        Even if the state update would be sent before the DBus response, it 
will be received from this code after the DBus response, as waitForFinished() 
waits
+       for the correct DBus response and queues any other DBus activity (such 
as the state update). Hence, the state update will always be received later than
+       waitForFinished() returns. Hence, the ussdInitiateComplete() call will 
contain the correct message, but the corresponding state update will only happen
+       (milliseconds) later.
     */
     reply.waitForFinished();
     if (reply.isError()) {
@@ -440,6 +441,10 @@
 void ModemManagerController::initAddedCall(const 
QSharedPointer<ModemManager::ModemDevice> &device, const 
QSharedPointer<ModemManager::Call> &call)
 {
     qDebug() << Q_FUNC_INFO << "call details:" << call->direction() << 
call->state() << call->stateReason();
+    if (getVoiceCallObject(device->uni(), call->uni())) {
+        // voice call object already exists, we do not need to append to list 
again
+        return;
+    }
     auto voiceCallObject = this->voiceCallObject(device, call, this);
     m_calls.append(voiceCallObject);
     connect(call.get(),
diff -Nru plasma-dialer-6.3.4/plasma-dialer/org.kde.plasma.dialer.appdata.xml 
plasma-dialer-6.3.5/plasma-dialer/org.kde.plasma.dialer.appdata.xml
--- plasma-dialer-6.3.4/plasma-dialer/org.kde.plasma.dialer.appdata.xml 
2025-04-02 05:37:43.000000000 +0200
+++ plasma-dialer-6.3.5/plasma-dialer/org.kde.plasma.dialer.appdata.xml 
2025-05-06 19:58:47.000000000 +0200
@@ -357,9 +357,9 @@
   </provides>
   <launchable type="desktop-id">org.kde.plasma.dialer.desktop</launchable>
   <releases>
+    <release version="6.3.5" date="2025-05-06"/>
     <release version="6.3.4" date="2025-04-01"/>
     <release version="6.3.3" date="2025-03-11"/>
     <release version="6.3.2" date="2025-02-25"/>
-    <release version="6.3.1" date="2025-02-18"/>
   </releases>
 </component>

Reply via email to